Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove link color in "help" text in Rerun menu #2733

Closed
Tracked by #2670
martenbjork opened this issue Jul 18, 2023 · 0 comments · Fixed by #2872
Closed
Tracked by #2670

Remove link color in "help" text in Rerun menu #2733

martenbjork opened this issue Jul 18, 2023 · 0 comments · Fixed by #2872
Labels
ui concerns graphical user interface

Comments

@martenbjork
Copy link
Contributor

martenbjork commented Jul 18, 2023 •
edited
Loading

These links should just have a regular text color.

image image

If we want to signify that they are external links, we can add a more elegant design for that, like an "external link" icon.
@martenbjork martenbjork mentioned this issue Jul 18, 2023
Open
25 tasks
@Wumpf Wumpf added the ui concerns graphical user interface label Jul 18, 2023
@abey79 abey79 mentioned this issue Jul 31, 2023
Merged
3 tasks
abey79 added a commit that referenced this issue Jul 31, 2023
@abey79
Change the styling of hyperlinks (#2872)
5f783cc 
### What

This PR changes the styling and behaviour of hyperlinks, of which there
are currently ~~two~~ three:

1) The "Help" item in the menu. I changed it to behave just like a
normal menu item does. On click, it'll *always* open a new tab, which is
a departure from the current behaviour where opening in a new tab
required a modifier (alt, etc.) or a middle-click. I believe this
behaviour respects better the "rule of least astonishment" in the case
of WASM builds. (For native build, it doesn't change anything.)
2) ~~The link in the "About" panel. For this I just changed the style to
use "normal" colour (ie. white), but keep the link behaviour (underline
on hover).~~ The link in the about panel is removed entirely as it is
redundant with the top-bar gigantilink.
3) The gigantilink, which has its own image-based styling (which will
soon be revisited). This PR changes its behaviour to open link in new
tab.

>[!WARNING]
>~~The forced "new tab" triggered the popup blocker on my computer, so
that maybe a motivation to stick with opening help in the same tab by
default. Opinions?~~ Opening in new tab used to—and will continue
to—trigger popup blocker. This is due to the browser not being aware
that some user interaction occurred within the wasm executable.

Fixes #2733 

Before:

<img width="496" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/4e002345-33a9-48ea-9474-b4404f6cc77f">


After (mouse hovering on link, thus the underline):

<img width="495" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/1ea91a13-5bf3-4d4d-aa76-60aaacf1c22b">



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2872) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2872)
- [Docs
preview](https://rerun.io/preview/pr%3Aantoine%2Fhyperlink-style-2733/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aantoine%2Fhyperlink-style-2733/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the styling and behavior of hyperlinks rerun-io/rerun
2 participants
@martenbjork @Wumpf