Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: 0.8 #2779

Closed
11 tasks done
jleibs opened this issue Jul 21, 2023 · 1 comment
Closed
11 tasks done

Release: 0.8 #2779

jleibs opened this issue Jul 21, 2023 · 1 comment
Labels
⛴ release Related to shipping or publishing
Milestone
0.8

Comments

@jleibs
Copy link
Member

jleibs commented Jul 21, 2023 •
edited by teh-cmc
Loading

Things to cover in release notes

  • Blueprint storage disabled on web.
  • transform visualization
  • highlight some bugfixes?
  • pinhole XYZ viewcoordinates stuff
  • extrinsics and intrinsics can be logged on same path
  • upcoming python & c++ apis
  • 2D / 3D Space Views are now separate types
  • Rust serve api

Regressions to fix before release:

Other easy bugs to fix before release
@jleibs jleibs added the ⛴ release Related to shipping or publishing label Jul 21, 2023
@Wumpf Wumpf mentioned this issue Jul 25, 2023
Merged
3 tasks
Wumpf added a commit that referenced this issue Jul 25, 2023
@Wumpf
Fix blueprint heuristic updates getting lost unless there were manual…
4b83b60 
… changes earlier (#2808)

### What

The issue was easiest to observe in the transform demo which relies
completely on heuristics to display anything (all transform arrows have
a configurable size): On startup or after reset nothing is visible until
something was selected. This happened because `class.prepare_ui` sets
the size (via heuristic) on the blueprint but `class.ui` would see the
propagated results only by next frame. At this point we discard the
entire blueprint unless there are manual changes. It seems changing the
selection in the blueprint alone is enough to trigger such a change.

To fix this I'm now simply applying the heuristic changes in the same
frame.

However, there seems to be a deeper underlying issue where until the
first selection (or other change) is done we're discarding the blueprint
every frame - once something is selected `sync_space_view` will
overwrite the previous snapshot and heuristic results will be applied.
This might be intended but seems rather odd. Expecation is that a lot of
this will go away once we reworked blueprints/properties as planned. cc:
@jleibs

part of #2779 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2808) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2808)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-transforms-not-shown-on-startup/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-transforms-not-shown-on-startup/examples)
@abey79 abey79 added this to the 0.8 milestone Jul 25, 2023
@Wumpf
Copy link
Member

Wumpf commented Jul 28, 2023

it was done!

@Wumpf Wumpf closed this as completed Jul 28, 2023
@nikolausWest nikolausWest modified the milestone: 0.8 Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⛴ release Related to shipping or publishing
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
4 participants
@Wumpf @nikolausWest @jleibs @abey79