Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++: Add standalone user-defined archetype+component example #3139

Closed
2 of 3 tasks
Tracked by #2919
teh-cmc opened this issue Aug 29, 2023 · 3 comments · Fixed by #4309
Closed
2 of 3 tasks
Tracked by #2919

C++: Add standalone user-defined archetype+component example #3139

teh-cmc opened this issue Aug 29, 2023 · 3 comments · Fixed by #4309
Assignees
@Wumpf
Labels
🌊 C++ API C/C++ API specific examples Issues relating to the Rerun examples 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Milestone
0.11

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Aug 29, 2023 •
edited
Loading

Once the new as_components()-based API land, we'll need an example to showcase how one can:

  • Define a custom archetype
  • Define a custom component
  • Extend an existing archetype

For example: implement a user.MyPoints3D archetype which "embeds" a rerun.archetypes.Points3D archetype and augments it with a custom user.Confidence component.

  • Python
  • Rust
  • C++
@teh-cmc teh-cmc added 🐍 Python API Python logging API 🦀 Rust API Rust logging API examples Issues relating to the Rerun examples 🌊 C++ API C/C++ API specific labels Aug 29, 2023
@emilk
Copy link
Member

emilk commented Sep 25, 2023 •
edited
Loading

A lot of this is already done in docs/code-examples/custom_data.py and docs/code-examples/custom_data.rs - what is missing?

@teh-cmc
Copy link
Member Author

teh-cmc commented Sep 25, 2023

what is missing?

C++

@Wumpf
Copy link
Member

Wumpf commented Oct 2, 2023

We're done for 0.9 here in that case. C++ is part of 0.10

@Wumpf Wumpf mentioned this issue Oct 24, 2023
Closed
33 tasks
@Wumpf Wumpf modified the milestones: 0.10 C++, 0.11 C++ polish Oct 24, 2023
@emilk emilk changed the title Add standalone user-defined archetype+component example C++: Add standalone user-defined archetype+component example Nov 6, 2023
@emilk emilk removed this from the 0.11 milestone Nov 21, 2023
@Wumpf Wumpf added this to the 0.11 milestone Nov 22, 2023
@Wumpf Wumpf self-assigned this Nov 22, 2023
@Wumpf Wumpf mentioned this issue Nov 22, 2023
Merged
4 tasks
Wumpf added a commit that referenced this issue Nov 23, 2023
@Wumpf
Add C++ Custom Component example (#4309)
78f3358 
### What

**&** refactor `rerun::Loggable` to be only producing an the
`arrow::Array`.

This further aligns Rust and C++ apis which can be best seen in the new
example which looks very similar to its rust counterpart \o/

* Fixes #3139
* Depends on / followup of #4305

`DataCell` took over part of the job that `rerun::Loggable` had so far:
type registration and putting together the `DataCell` - `to_data_cell`
got renamed to `to_arrow` for this purpose. Everything else after that
just clicked into place :).

Did a few manual runs of the log benchmark to ensure that this didn't
regress anything.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4309) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4309)
- [Docs
preview](https://rerun.io/preview/c5f807af263a1a02a734a499bcd22754dc0646ea/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/c5f807af263a1a02a734a499bcd22754dc0646ea/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🌊 C++ API C/C++ API specific examples Issues relating to the Rerun examples 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

Add C++ Custom Component example rerun-io/rerun
3 participants
@emilk @Wumpf @teh-cmc