-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zooming in changes orbital camera origin #4402
Comments
@emilk this is caused by the "move once too close" rule you added to the orbit camera. This ticket would essentially require dropping that again entirely. Not sure if that's what we want to do 🤔 |
Oh, is this what's going on? I am very frequently inconvenienced by the orbit point not being anywhere near the place it ought to be, and now I understand that it's probably a combination of this behavior and #4664. |
The reason for the current behavior is that scrolling means "move closer", but for some users it can be confusing that you cannot get any closer after a while (because you are approaching the orbital center). So we added the feature that when you are very close to the orbital center, scroll moves it. I can see how that is confusing though. We could remove the "scroll to move" and replace it with some hint to the user, e.g. showing the orbital center as being very close when you scroll too close to it, perhaps with a suggestion to move it instead using WSAD |
Probably having fixed #4664 will reduce the incidence of doing that unintentionally.
That sounds nice. I added this to my list in #4666 since that is very closely related. |
### What With this PR, we show the orbit center when using WSAD (and when focusing on an entity). This makes it much easier to position the orbit center exactly where you want it. I also removed the scroll-to-move "feature" * Closes #4402 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4943/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4943/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4943/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4943) - [Docs preview](https://rerun.io/preview/efde01b58c234ac13d26c464239ce5015f770641/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/efde01b58c234ac13d26c464239ce5015f770641/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Currently when zooming in (beyond a certain point?) the origin of the orbital camera seems to change. I think this is not intuitive. I would never expect zoom in + zoom out result in a different origin position.
See video below (only zooming in and out after 0:15).
2023-11-30.10-12-10.mp4
Somewhat related to #965, but different issue.
To Reproduce
Align origin with one of the points (like in the video), zoom far in, zoom out -> origin not at the same position anymore.
The text was updated successfully, but these errors were encountered: