-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DisconnectSpace and TimeSeriesScalar #4465
Comments
Thanks for filing the issue! This is indeed a bug the way .. but as things are this is a bug as described. |
The plan is that setting up spaceviews should be done via the new blueprint API when this issue is done: |
### What * Part of #4388 * Fixes #4465 This PR only addresses the documentation. `main` is actually in a slightly mixed state right now: Visualizability is already determined strictly with `DisconnectedSpace` only applying to spatial views, but we still have the legacy `SpaceInfo` used in some places that applies this concept to everything. This will be removed in a a follow-up. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4935/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4935/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4935/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4935) - [Docs preview](https://rerun.io/preview/4eec4acd74c6d5a8f132bd8490895ae45e90aac7/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/4eec4acd74c6d5a8f132bd8490895ae45e90aac7/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Describe the bug
rerun_example_disconnect_space does not work if TimeSeriesScalar is logged in python.
To Reproduce
Steps to reproduce the behavior:
Run:
Look in the viewer for disconnected spaces.
Expected behavior
Two different spaces should be shown, but as stated, all signals are shown in one single space.
Screenshots
Desktop:
Rerun version
rerun_py 0.10.1 [rustc 1.72.1 (d5c2e9c34 2023-09-13), LLVM 16.0.5] x86_64-unknown-linux-gnu release-0.10.1 e596e4e, built 2023-11-02T16:05:55Z
The text was updated successfully, but these errors were encountered: