Clean up the torch and torch vision python 3.12 gating when PyTorch is 3.12-compatible
#4704
Labels
🧑💻 dev experience
developer experience (excluding CI)
Comments
abey79
added
😤 annoying
jleibs
pushed a commit
that referenced
this issue
Jan 5, 2024
### What * Bumps arrow to 14.0.2 * Fixes #3699 * Relates to #2445 I added a bunch of fixes to `scripts/run_all.py`, which has a marked tendency to bit rot: * #4710 Some workaround introduced to deal with PyTorch not 3.12 ready, see: - #4704 TODO: - [x] `nox -s tests-3.12` passing - [x] `nox -s run_all-3.12 --save` passing - [x] `nox -s roundtrips-3.12` passing - [x] Solve this: ``` ❯ pixi add pyarrow==14.0.0 × could not determine any available versions for pyarrow on linux-64. Either the package could not be found or version constraints on other dependencies result in a conflict. ╰─▶ Cannot solve the request because of: No candidates were found for pyarrow ==14.0.0. ``` - [x] Test won't pass until torch is updated for 3.12: pytorch/pytorch#110436 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4146) (if applicable) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4146) - [Docs preview](https://rerun.io/preview/c0e892a228fcc83e9bef7faff1e17998926ffe52/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/c0e892a228fcc83e9bef7faff1e17998926ffe52/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
|
Related pytorch issues: |
abey79
added a commit
that referenced
this issue
Apr 10, 2024
### What - closes #4704 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [rerun.io/viewer](https://rerun.io/viewer/pr/5899) * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5899?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/5899?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5899) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clean up the patches introduces by:
Look for
TODO(#4704)in the repo...The text was updated successfully, but these errors were encountered: