Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected selection panel UI when removing an entity #5406

Closed
abey79 opened this issue Mar 5, 2024 · 3 comments · Fixed by #5643
Closed

Unexpected selection panel UI when removing an entity #5406

abey79 opened this issue Mar 5, 2024 · 3 comments · Fixed by #5643
Assignees
@Wumpf
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Milestone
0.15

Comments

@abey79
Copy link
Member

abey79 commented Mar 5, 2024

Repro:

  • plots example
  • reset blueprint
  • remove "parabola" from the "curves" space view
  • now the "curves" entity path has a different selection panel with red warnings
remove_entity_bug_2.mp4
@abey79 abey79 added 🪳 bug Something isn't working ui concerns graphical user interface 🦟 regression A thing that used to work in an earlier release labels Mar 5, 2024
@abey79 abey79 added this to the 0.15 milestone Mar 5, 2024
@abey79 abey79 mentioned this issue Mar 5, 2024
Merged
5 tasks
abey79 added a commit that referenced this issue Mar 6, 2024
@abey79
More context menu 3: add support for removing DataResult from a spa…
70fc212 
…ce view (#5407)

### What

As the title says ☝🏻 

Will easily trigger:
- #5404
- #5406


<img width="321" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/e996ade1-2ad7-42a5-8b9a-852149d653a3">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5407/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5407/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5407/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5407)
- [Docs
preview](https://rerun.io/preview/4a94ddc1c02addd3e7a45a9241dcf57eade1df91/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/4a94ddc1c02addd3e7a45a9241dcf57eade1df91/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf
Copy link
Member

Wumpf commented Mar 6, 2024

Happens with all entities once "Visualizer selection for all views" is enabled

@Wumpf
Copy link
Member

Wumpf commented Mar 22, 2024

this got already fixed for remove item context menu, but not that remove button

@Wumpf Wumpf removed the 🦟 regression A thing that used to work in an earlier release label Mar 22, 2024
@Wumpf Wumpf self-assigned this Mar 22, 2024
@Wumpf Wumpf mentioned this issue Mar 22, 2024
Merged
5 tasks
@abey79
Copy link
Member Author

abey79 commented Mar 22, 2024

Oh yeah. Needs the same remove from selection treatment.

Wumpf added a commit that referenced this issue Mar 22, 2024
@Wumpf
Remove items from selection upon removal consistently (#5643)
84d19d1 
### What

This was done in various places and somewhat inconsistently. This change
unifies selection & history purging as well as selection fallback.

* Fixes  #5406

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5643/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5643/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5643/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5643)
- [Docs
preview](https://rerun.io/preview/9f723b58c2966da96bad42369c51c8d8f77d3c97/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/9f723b58c2966da96bad42369c51c8d8f77d3c97/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Be consistent in how items are removed from selection rerun-io/rerun
2 participants
@Wumpf @abey79