Blueprint tree: provide feedback when a data result not visualisable #5410
Labels
Milestone
Comments
abey79
added
ui
5 tasks
abey79
added a commit
that referenced
this issue
Mar 7, 2024
…5411) ### What As the title says ☝🏻 * Fixes #5299 Also adds a "no action available for this selection" notice that got lost in #5392. Makes it very easy to bump into: - #5410 https://github.com/rerun-io/rerun/assets/49431240/d3bafbf4-3755-4f6f-b236-bd1d022b172f #### Design decisions - The origin of the newly created space view is set to "/" - Alternative 1: set it to the clicked item. Strong reject: too arcane, different results for the same multi-selection depending on which item is actually clicked. - Alternative 2: set it to the common ancestor of all selected entities. Weak reject: less predictable, occasionally wrong (but works around some visualisable issue we have with some space views). - We show a list of suggested space view classes. - The list is the *intersection* of the suggested classes for each of the selected entities. - For each entity, the suggested classes are determined based on the *union* of suggested classes for the entity itself, *and for every entity of its subtree*. This enables meaningful suggestion when selecting a pure TreePrefix. - The newly created space view is selected. #### Known "phenomenons" - 2D space views are rarely suggested, because of the origin is set to "/" and that's outside of a pinhole transform. - TODO: issue number? - Text Document and Text Log are often suggested for time series scalar, because of the `Text` document. - Tensor is recommended but will (sometime?) display nothing, e.g. `structure_from_motion` -> `/camera/image` - If enabled, Dataframe is always the top-most suggested Space View, because of the lexicographic sorting. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5411/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5411/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5411/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5411) - [Docs preview](https://rerun.io/preview/979f2768f87bd3e72b45c80ffd319b56661f138e/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/979f2768f87bd3e72b45c80ffd319b56661f138e/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
5 tasks
abey79
added a commit
that referenced
this issue
Mar 20, 2024
…#5600) ### What I posit that displaying visibility is more important than visualizability in the blueprint tree. This PR stops confounding both aspects in the styling. - Fixes #5469 Before/after: <img width="188" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/1772f396-225f-4a4d-a25f-4f66e0ab7b4c"> <img width="247" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/3e485645-ff07-4f89-b70a-6c1e99bc9b3c"> <br/><br/> It would still be interesting to somehow display visualizability there. We need a design for that. - Relates to #5410 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5600/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5600/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5600/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5600) - [Docs preview](https://rerun.io/preview/b2e30f22c442163dfed3b12dbb7df4585e1fba8c/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/b2e30f22c442163dfed3b12dbb7df4585e1fba8c/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
|
Requires some design |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, if a data result is not visualisable, it is displayed as it it was hidden (see the tensor with 3d points in screenshot).
We should clearly indicate that that this data result is not visualisable in the context of this space view:
The text was updated successfully, but these errors were encountered: