Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinhole with single image no longer creates a 3D view #5553

Closed
Wumpf opened this issue Mar 18, 2024 · 0 comments · Fixed by #5563
Closed

Pinhole with single image no longer creates a 3D view #5553

Wumpf opened this issue Mar 18, 2024 · 0 comments · Fixed by #5563
Assignees
@Wumpf
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Milestone
0.15

Comments

@Wumpf
Copy link
Member

Wumpf commented Mar 18, 2024 •
edited
Loading

https://discord.com/channels/1062300748202921994/1075873257124810852/1214908729321988166

This script doesn't show a 3D scene when it should

import numpy as np
import rerun as rr

rr.init("rerun_example_pinhole", spawn=True)
rng = np.random.default_rng(12345)

image = rng.uniform(0, 255, size=[3, 3, 3])
rr.log("world/image", rr.Pinhole(focal_length=3, width=3, height=3))
rr.log("world/image", rr.Image(image))

Originally posted by @Wumpf in #5455 (comment)
@Wumpf Wumpf added 🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release labels Mar 18, 2024
@Wumpf Wumpf added this to the 0.15 milestone Mar 18, 2024
@Wumpf Wumpf self-assigned this Mar 18, 2024
@Wumpf Wumpf added the 📺 re_viewer affects re_viewer itself label Mar 18, 2024
@Wumpf Wumpf mentioned this issue Mar 18, 2024
Merged
5 tasks
Wumpf added a commit that referenced this issue Mar 18, 2024
@Wumpf
Fix recommendation from one Space View class affecting recommendation…
b068aa7 
… from another (#5554)

### What

This broke recently due to the tracking of space view recommendation
hashes _without_ taking into account their class.
Cleaned up the whole thing a little bit in the progress.

* Fixes #5455
* Also mentioned on this ticket is this issue but it turned out to be
unrelated (thus now a separate ticket) #5553
    * #5455 is new to 0.15alpha, but #5553 happens on 0.14!

---

For this script:
```py
import rerun as rr

rr.init("rerun_example_bug")
rr.connect()
rr.set_time_sequence("frame_nr", 0)

rr.log("boxes3d", rr.Boxes3D(centers=[[0, 0, 0], [1, 1.5, 1.15], [3, 2, 1]], half_sizes=[0.5, 1, 0.5] * 3))
rr.log("boxes2d", rr.Boxes2D(centers=[[0, 0], [1.3, 0.5], [3, 2]], half_sizes=[0.5, 1] * 3))
rr.log("text_logs", rr.TextLog("Hello, world!", level=rr.TextLogLevel.INFO))
rr.log("points2d", rr.Points2D([[0, 0], [1, 1], [3, 2]], labels=["a", "b", "c"]))
```

Before: Only text view visible.

After:
<img width="1425" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/b6491052-9ae1-4199-a515-1f457515a7ec">



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5554/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5554/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5554/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5554)
- [Docs
preview](https://rerun.io/preview/707ea2ce9502cfeb726292ae7e43ee8b8a705e92/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/707ea2ce9502cfeb726292ae7e43ee8b8a705e92/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf Wumpf mentioned this issue Mar 18, 2024
Merged
5 tasks
Wumpf added a commit that referenced this issue Mar 19, 2024
@Wumpf
Fix not creating 3D space views for pinhole-only 3D scenes (#5563)
4d2a8b9 
### What

* Fixes #5553

`python
/Users/andreas/dev/rerun-io/rerun/docs/snippets/all/pinhole_simple.py`



Before (0.14):

![image](https://github.com/rerun-io/rerun/assets/1220815/1b447151-86a1-4873-9283-905e0276a9b0)


After:

![image](https://github.com/rerun-io/rerun/assets/1220815/f7f0d75b-0866-4f3b-9322-570b1f60deb2)



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/{{pr.number}}/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/{{ pr.number }})
- [Docs preview](https://rerun.io/preview/{{ pr.commit }}/docs)
<!--DOCS-PREVIEW-->
- [Examples preview](https://rerun.io/preview/{{ pr.commit }}/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Fix: allow creating 3D space views for pinhole-only 3D scenes rerun-io/rerun
1 participant
@Wumpf