Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show software rasterizer warning in title bar #5596

Closed
Wumpf opened this issue Mar 20, 2024 · 3 comments · Fixed by #5655
Closed

Show software rasterizer warning in title bar #5596

Wumpf opened this issue Mar 20, 2024 · 3 comments · Fixed by #5655
Assignees
Labels
🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself
Milestone

Comments

@Wumpf
Copy link
Member

Wumpf commented Mar 20, 2024

It's easy to accidentally run on Linux into a situation where Rerun is rendered using the software rasterizer, quickly leading to abyssmal performance. We log a warning on commandline but it's easy to miss.

Simply style it like our "Debug Build" warning and have it link to the troubleshoot guide.

(The troubleshoot guide is not always helping out with this right now, but that's a separate issue we (and wgpu) have to work on)

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🏎️ Quick Issue Can be fixed in a few hours or less labels Mar 20, 2024
@Wumpf Wumpf added this to the 0.15 milestone Mar 20, 2024
@emilk
Copy link
Member

emilk commented Mar 20, 2024

Even better would be to show all logged warnings and errors in an easily visible way, i.e. as a "notification" bar in the top bar. We used to have an issue for this, but now I can't find it.

@Wumpf
Copy link
Member Author

Wumpf commented Mar 20, 2024

agreed, our log notification system needs an overhaul. But let's stick with the simple thing here :)

@Wumpf
Copy link
Member Author

Wumpf commented Mar 20, 2024

Separate issue for that here:

EDIT: Found the original now which was better:

@emilk emilk self-assigned this Mar 22, 2024
emilk added a commit that referenced this issue Mar 25, 2024
### What
* Closes #5596

![software-rasterizer](https://github.com/rerun-io/rerun/assets/1148717/ccab5b1d-fb40-4c0d-9379-8bf00aa73725)


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5655/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5655/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5655/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5655)
- [Docs
preview](https://rerun.io/preview/4b8237229e8245e6b38dc915d52fc6d25fb34c95/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/4b8237229e8245e6b38dc915d52fc6d25fb34c95/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants