Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join our Rust "scripts" crates into one #5889

Closed
emilk opened this issue Apr 10, 2024 · 0 comments · Fixed by #5972
Closed

Join our Rust "scripts" crates into one #5889

emilk opened this issue Apr 10, 2024 · 0 comments · Fixed by #5972
Assignees
Labels
🧑‍💻 dev experience developer experience (excluding CI)

Comments

@emilk
Copy link
Member

emilk commented Apr 10, 2024

We (well, @jprochazk) have started porting more and more .sh and .py scripts to Rust, and so far I think it has been a win. However, so far each such "Rust script" has become its own separate crate, which I think is the wrong direction:

So, I think we should consider an xtask-esque approach, where a single Rust binary multiplexes out into different Rust "scripts", so that each script is just a file added to the same crate.

@emilk emilk added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 10, 2024
@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) and removed enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Apr 10, 2024
@Wumpf Wumpf self-assigned this Apr 15, 2024
Wumpf added a commit that referenced this issue Apr 15, 2024
### What

* Fixes #5889

Puts a bunch of tooling under a new extensible home.

```
pixi run dev-tools --help
✨ Pixi task (default): cargo run -q --locked -p re_dev_tools -- --help
Usage: re_dev_tools <command> [<args>]

Various development tools for Rerun.

Options:
  --help            display usage information

Commands:
  build-examples    Build examples and their manifest.
  build-web-viewer  Build the web-viewer.
  search-index      Meilisearch indexer and REPL
```

Intentionally left out `re_types_builder` since it's fairly big on its
own.


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5972?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5972?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5972)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants