Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable background color for 2D spatial space view #6113

Closed
Tracked by #6083
emilk opened this issue Apr 25, 2024 · 0 comments · Fixed by #6116
Closed
Tracked by #6083

Configurable background color for 2D spatial space view #6113

emilk opened this issue Apr 25, 2024 · 0 comments · Fixed by #6116
Assignees
@emilk
Labels
🟦 blueprint The data that defines our UI enhancement New feature or request 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself

Comments

@emilk
Copy link
Member

emilk commented Apr 25, 2024 •
edited
Loading

Let's rename Background3D and reuse it
@emilk emilk added enhancement New feature or request 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself 🟦 blueprint The data that defines our UI labels Apr 25, 2024
@emilk emilk self-assigned this Apr 25, 2024
This was referenced Apr 25, 2024
Closed
Merged
emilk added a commit that referenced this issue Apr 26, 2024
@emilk @Wumpf
Change background of 2D space views from code and/or UI (#6116)
c203d4e 
### What
* closes #6113

Very similar to 3D space views, even using the same gradient by default.
Usage:

```py
rrb.Spatial2DView(origin="/foo", background=[32, 0, 16])
```

The default background color is still BLACK.

---

Here the dark gradient is used.
It looks a little bit too much like the 3D space view.
<img width="916" alt="Screenshot 2024-04-25 at 18 12 05"
src="https://github.com/rerun-io/rerun/assets/1148717/46ee32d8-7234-43d7-b867-c037ad011865">

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6116?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6116?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6116)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

---------

Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🟦 blueprint The data that defines our UI enhancement New feature or request 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change background of 2D space views from code and/or UI rerun-io/rerun
1 participant
@emilk