-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a proper widget to use with notebooks #6518
Labels
notebook
Jupyter notebooks etc
Comments
Proposal for possible steps:
|
jprochazk
added a commit
that referenced
this issue
Jun 24, 2024
### What - Closes #6518 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6573?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6573?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6573) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Out jupyter notebooks currently use some awkward hacks that involve returning an html snippet containing a base64-encoded RRD, an iframe pointing at a rerun instance, and some javascript to stitch everything together.
Although this is functional, it's sub-optimal for numerous reasons:
All of the original work predates having our
rerun-io/web-viewer
npm package, and any of the things we've learned about streaming via the gradio interface.The right thing to do going forward is to create a proper jupyter widget, which would allow the notebook to host the assets (avoiding CORS issues), and tunneling any data through the proper notebook data-transmission mechanism.
I suspect anywidget might be a good candidate for achieving this. It looks like there are even ways to use anywidget with svelte components: https://gist.github.com/manzt/af46972d7a0a8e870f5228da66c52891
The text was updated successfully, but these errors were encountered: