Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto download ffmpeg & arbitrary ffmpeg path #8004

Open
Wumpf opened this issue Nov 5, 2024 · 1 comment
Open

Auto download ffmpeg & arbitrary ffmpeg path #8004

Wumpf opened this issue Nov 5, 2024 · 1 comment
Assignees
@Wumpf
Labels
enhancement New feature or request 🎞️ video

Comments

@Wumpf
Copy link
Member

Wumpf commented Nov 5, 2024

introduced basic handling of missing ffmpeg & a way to download.
Now that ffmpeg-sidecar is using ureq, we should add a proper download button that allows the user to pick where to.

In consequence then we'd set an internal app setting that is exposed in the new settings screen that @abey79 is building where a user can configure which ffmpeg is being used
@Wumpf Wumpf added enhancement New feature or request 🎞️ video labels Nov 5, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Nov 5, 2024 •
edited
Loading

option menu coming in here!

@Wumpf Wumpf self-assigned this Nov 5, 2024
@abey79 abey79 mentioned this issue Nov 12, 2024
Merged
6 tasks
emilk pushed a commit that referenced this issue Nov 13, 2024
@abey79
Make the path to ffmpeg customisable (#8100)
d85280c 
### What

Makes the path to `ffmpeg` customisable. Also hides the auto/soft/hard
choice on native as it has not impact.

- Part of #8004



https://github.com/user-attachments/assets/4c76a3f1-407d-40ed-84a4-bdc20b25f22f



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8100?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/8100?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/8100)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
enhancement New feature or request 🎞️ video
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wumpf