Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust update and workspace inheritance #110

Merged
merged 6 commits into from
Oct 4, 2022

Conversation

jondo2010
Copy link
Contributor

  • Update pinned Rust version to 1.64.0
  • Make use of the workspace inheritance features for the package table

This is currently blocked on PyO3/maturin#1122 (Fixed in PyO3/maturin#1123)

@jondo2010 jondo2010 added the blocked can't make progress right now label Sep 23, 2022
@jondo2010 jondo2010 marked this pull request as ready for review September 23, 2022 15:26
@emilk emilk marked this pull request as draft September 27, 2022 13:37
- Make use of the workspace inheritance features for the package table
- Bumped Rust version in the github workflows
- Added changelog line
- Upgrade maturin to 0.13.5
…t_and_1_63_upgrade

# Conflicts:
#	Cargo.toml
#	examples/objectron/Cargo.toml
@jondo2010 jondo2010 force-pushed the john/workspace_inherit_and_1_63_upgrade branch from cc56dca to c3ff356 Compare October 4, 2022 09:45
@jondo2010 jondo2010 removed the blocked can't make progress right now label Oct 4, 2022
@jondo2010 jondo2010 marked this pull request as ready for review October 4, 2022 09:45
@jondo2010
Copy link
Contributor Author

Important for testing: maturin needs to be upgraded from previous version. Run just py-dev-env to pull in the latest version specified in the requirements-build.txt

@jondo2010 jondo2010 requested a review from emilk October 4, 2022 11:42
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@jondo2010 jondo2010 merged commit 403b944 into main Oct 4, 2022
@jondo2010 jondo2010 deleted the john/workspace_inherit_and_1_63_upgrade branch October 4, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants