datastore: make Objects methods exhaustive
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
approved these changes
Oct 3, 2022
| @@ -623,7 +623,30 @@ impl<'s> Objects<'s> { | |||
| } | |||
|
|
|||
| pub fn is_empty(&self) -> bool { | |||
| self.space.is_empty() && !self.has_any_2d() && !self.has_any_3d() | |||
| let Self { | |||
There was a problem hiding this comment.
Just making sure I understand the intent: by destructing Self into it's fields we ensure that if somebody adds to to the Objects struct they will also have to change this line of code and will be more likely to add the necessary support?
There was a problem hiding this comment.
Exactly!
Props to @emilk, I had completely forgotten about that trick 🙃
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objectscurrently has some implicit invariants that can potentially lead to data being silently dropped if you're not aware of them.This PR makes sure to check those invariants at compile time.