Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill out archetype docs: Transform3d, Pinhole, Scalar, TextEntry #2473

Merged
merged 10 commits into from
Jun 19, 2023

Conversation

nikolausWest
Copy link
Member

@nikolausWest nikolausWest commented Jun 19, 2023

Simple first pass on adding python examples for archetypes:

  • Transform3d
  • Pinhole
  • Scalar
  • TextEntry

@nikolausWest nikolausWest added the 📖 documentation Improvements or additions to documentation label Jun 19, 2023
@nikolausWest nikolausWest changed the title Fill out more archetype docs Fill out archetype docs: Transform3d, Pinhole, Scalar, TextEntry Jun 19, 2023
@nikolausWest nikolausWest requested review from jleibs and abey79 June 19, 2023 13:57
@nikolausWest nikolausWest marked this pull request as ready for review June 19, 2023 13:57
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comment tweaks, but otherwise looks great.

docs/code-examples/transform3d_simple.py Outdated Show resolved Hide resolved
docs/code-examples/text_entry_simple.py Outdated Show resolved Hide resolved
docs/code-examples/text_entry_simple.py Show resolved Hide resolved
docs/code-examples/text_entry_simple.py Show resolved Hide resolved
nikolausWest and others added 4 commits June 19, 2023 16:09
Co-authored-by: Jeremy Leibs <[email protected]>
Co-authored-by: Jeremy Leibs <[email protected]>
Co-authored-by: Jeremy Leibs <[email protected]>
Co-authored-by: Jeremy Leibs <[email protected]>
@nikolausWest nikolausWest merged commit 049bce2 into main Jun 19, 2023
@nikolausWest nikolausWest deleted the niko/more-archetype-docs branch June 19, 2023 14:48
jleibs added a commit that referenced this pull request Jun 20, 2023
…n image (#2474)

### What

Fill out more archetype docs:
- image
- tensor
- depth image
- segmentation image

Follow up to:
- #2467 

In parallel to:
- #2473 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [ ] ~~I've included a screenshot or gif (if applicable)~~

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2474

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/7925ce9/docs
Examples preview: https://rerun.io/preview/7925ce9/examples
<!-- pr-link-docs:end -->

---------

Co-authored-by: Nikolaus West <[email protected]>
Co-authored-by: Nikolaus West <[email protected]>
Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants