Memory pruning #299
Merged
Memory pruning #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
commented
Nov 19, 2022
emilk
commented
Nov 19, 2022
emilk
force-pushed
the
emilk/mem-pruning
branch
from
fca6a5b to
3808119
Compare
emilk
force-pushed
the
emilk/mem-pruning
branch
from
48dae5f to
cd41997
Compare
teh-cmc
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first-effort to implement memory pruning, i.e. to keep the memory use of Rerun Viewer below some certain threshold.
Example:
RERUN_MEMORY_LIMIT=2GB cargo r -- ../objectron.rrd. The pruning limit is not yet set-able on web (and is always off there).This PR also introduces a memory panel where you can see the current memory use:
This PR does the pruning by removing the oldest half of each timeline. Another strategy would be to use the common time now stored in
MsgId, but that relies onMsgIdremaining a time-based ID, which may be something we walk back on once we switch to Arrow.There is still quite a bit of memory not beeing freed. I will investigate where and why after this PR is merged.