Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextDocument archetype #3173

Merged
merged 16 commits into from
Sep 7, 2023
Merged

TextDocument archetype #3173

merged 16 commits into from
Sep 7, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 31, 2023 •
edited by github-actions bot
Loading

What

  • Rename datatypes.Label to datatypes.utf8
  • Rename components.Label to components.Text
  • Add new archetypes.TextDocument { body: components.Text }

image

Checklist

@emilk emilk changed the title WIP: Text archetypes/components/datatypes WIP: codegen of text types Sep 1, 2023
@emilk emilk force-pushed the emilk/port-text branch 3 times, most recently from 5baad51 to 85c9997 Compare September 6, 2023 13:42
@emilk emilk added 🐍 Python API Python logging API 🦀 Rust API Rust logging API codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md labels Sep 6, 2023
@emilk emilk force-pushed the emilk/port-text branch 8 times, most recently from a1a7f65 to fcefc12 Compare September 6, 2023 15:44
@emilk emilk marked this pull request as ready for review September 6, 2023 15:51
@emilk emilk changed the title WIP: codegen of text types TextDocument archetype Sep 6, 2023
@teh-cmc teh-cmc self-requested a review September 7, 2023 07:10
@teh-cmc
Copy link
Member

teh-cmc commented Sep 7, 2023

I'll handle the rebase on top of the new roundtrip stuff, force push incoming ⚠️

teh-cmc
teh-cmc approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM except for a required component being queried as optional.

crates/re_sdk/src/msg_sender.rs Outdated Show resolved Hide resolved
crates/re_space_view_text_document/src/view_part_system.rs Outdated Show resolved Hide resolved
crates/re_space_view_text_document/src/view_part_system.rs Outdated Show resolved Hide resolved
docs/code-examples/text_document.py Outdated Show resolved Hide resolved
docs/code-examples/text_document.py Outdated Show resolved Hide resolved
tests/python/roundtrips/text_document/main.py Outdated Show resolved Hide resolved
@emilk emilk merged commit 0d6ada3 into main Sep 7, 2023
@emilk emilk deleted the emilk/port-text branch September 7, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
codegen/idl exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @teh-cmc