Continue end-to-end support for Images and Tensors #3237
Conversation
Size changes
|
jleibs
changed the title
jleibs
added
🐍 Python API
| @@ -46,7 +46,9 @@ pub fn data_cell_from_file_path(file_path: &std::path::Path) -> Result<DataCell, | |||
| #[cfg(feature = "image")] | |||
| _ => { | |||
| // Assume an image (there are so many image extensions): | |||
| let tensor = crate::Tensor::from_image_file(file_path)?; | |||
There was a problem hiding this comment.
Looks like this needs to add the indicator components.
There was a problem hiding this comment.
We can't really add an indicator component here until that is its own code-genned struct, which I believe @teh-cmc is working on
| ) { | ||
| TensorDataMeaning::ClassId | ||
| } else { | ||
| TensorDataMeaning::Unknown |
There was a problem hiding this comment.
We should check for the ColorImage::indicator_component here, and return TensorDataMeaning::Color instead, and use Unknown for when it is truly unknown
emilk
force-pushed
the
jleibs/tensor_image_queries
branch
from
ff53d77 to
4711404
Compare
|
Ouch, the example rrd files balloon because |
|
Ok, |
|
When green, I'm hitting merge |
|
Before implementing jpeg_quality:
After: So turns out |
|
Size-bot is lying - |
Tensor(and its many friends) migration to archetypes #2792What
Introduces DepthImage and SegmentationImage as additional archetypes, along with round-trip-tests and code-examples.
Deletes all of the old Image/Tensor related components.
Updates all the necessary places to derive meaning from the indicator components.
This still leaves Images ViewPartSystem as a monolithic system, but splits up the process calls into the 3 separate ArchetypeViews. There's a lot of duplicate code here that could definitely be factored out.
Still Needed for feature-parity with the old APIs.
I've added it as TODO:s on #2792
Things to investigate:
annotation_context_segmentationalthough both code-examples run fine on their own.Checklist