Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ as_components style & splatting #3258

Merged
merged 20 commits into from
Sep 8, 2023
Merged

C++ as_components style & splatting #3258

merged 20 commits into from
Sep 8, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Sep 7, 2023

What

Trigger of this PR was the inability to deal with mono components like DrawOrder -> need splatting -> don't want to implement splatting separately for components & archetype -> implement as_components-style

Quick throw-away test for splatting radius on the random point demo:
image

Checklist

@Wumpf Wumpf added 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md labels Sep 7, 2023
@Wumpf Wumpf force-pushed the andreas/cpp/splats branch from 9b7f7b8 to a89568a Compare September 7, 2023 17:22
@teh-cmc teh-cmc self-requested a review September 8, 2023 06:42
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall 👍 Just a handful of minor things.

crates/re_types_builder/src/codegen/cpp/mod.rs Outdated Show resolved Hide resolved
crates/re_types_builder/src/codegen/cpp/mod.rs Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/recording_stream.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/recording_stream.cpp Outdated Show resolved Hide resolved
crates/re_types_builder/src/codegen/cpp/mod.rs Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/archetypes/arrows3d.hpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/component_batch.hpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/recording_stream.hpp Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit 1488bd5 into main Sep 8, 2023
@Wumpf Wumpf deleted the andreas/cpp/splats branch September 8, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
2 participants