Restructure python codegen: move codegen to rerun and old log APIs to log_deprecated #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lready have the bytemuck dep
jleibs
commented
Sep 20, 2023
There was a problem hiding this comment.
Not technically a new file. Git is just confused because there's a new components/__init__.py in its place.
jleibs
commented
Sep 20, 2023
There was a problem hiding this comment.
Not technically a new file. Git is just confused because there's a new components/transform3d.py in its place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moves:
rerun.log.error_utils->rerun.error_utilsrerun.log.*->rerun.log_deprecated.*rerun.components.*->rerun.components_deprecated.*_rerun2.*->rerun.*Note, this required making the following changes in a few examples:
rr.log.rects.RectFormat->rr.RectFormatrr.log.text.LoggingHandler->rr.LoggingHandlerrr.log.annotation.AnnotationInfo->rr.AnnotationInfoAdditionally, all of the AffixFuzzer is now generated into its own module in
rerun_py.tests.test_typesDoes not yet move the new logging APIs out of
experimental, but all of that can be managed inrerun.__init__now.Checklist