Add a C++ example of BarChart with added ergonomics
#3837
Conversation
Plus all the plumbing needed to make that ergonomic
emilk
added
🌊 C++ API
|
|
||
| namespace rerun { | ||
| /// IEEE 754 16-bit half-precision floating point number. | ||
| struct half { |
There was a problem hiding this comment.
We can change this in the future - I just want a placeholder for now so that we don't have ugly holes in our C++ API
| // -------------------------------------------------------------------- | ||
| // Implicit constructors: |
There was a problem hiding this comment.
a bit redundant to call them "implicit constructors". All constructors are implicit unless they are explicitely marked as explicit
|
|
||
| #ifdef EDIT_EXTENSION | ||
| struct TensorDataExt { | ||
| #define TensorData TensorDataExt |
There was a problem hiding this comment.
Discussion topic: Maybe we should stop with those "emulated working enviroments" using defines and structs. I started putting them here to make the code compile if EDIT_EXTENSION is enabled and the code wasn't generated yet. But everyone else (well, also sometimes myself!) editing these files gets this wrong and copies the pattern without copying the part that actually make it compile :/
The only actually needed part is the comment markers and some means to make the code inside the comment marker not part of the sdk compilation (which is done with #ifdef EDIT_EXTENSION)
There was a problem hiding this comment.
Yeah, I'm just cargo-culting this. I'll leave it to you to clean up everywhere 😬
There was a problem hiding this comment.
😄 . Feel free to keep this unchanged in this pr!
What
Checklist