Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ examples & roundtrip tests for image/segmentation-image/depth-image/tensor #3899

Merged
merged 24 commits into from
Oct 18, 2023
Merged

C++ examples & roundtrip tests for image/segmentation-image/depth-image/tensor #3899

merged 24 commits into from
Oct 18, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Oct 17, 2023 •
edited
Loading

What

commit history is a bit messy because this was based on the annotation context example pr. Speaking off, I made those a bit nicer on the way

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested demo.rerun.io (if applicable)
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG

Wumpf added 17 commits October 17, 2023 11:06
@Wumpf
Implement annotation_context_connections for C++
79466db
@Wumpf
annotation_context_segmentation sample for C++
e261fd1 
necessary segmentation image improvements
@Wumpf
unit test for SegmentationImage behavior
a62b9dc
@Wumpf
remove extremely helpful comment to satisfy spellchecker
6de4c7e
@Wumpf
fix extra curly
2f746b7
@Wumpf
fix extra whitespaces on embedded examples
7d5a367
@Wumpf
add depth image and depth image simple examples for C++
ee4c7e2
@Wumpf
shorten examples with images a bit
e8d0159
@Wumpf
image_simple example
70b28fa
@Wumpf
Merge remote-tracking branch 'origin/main' into andreas/cpp/images
cc09900
@Wumpf
More validation, add image tests
8ebbc74
@Wumpf
segmentation image example for C++
b480315
@Wumpf
add roundtrip tests for depth & segmentation image, stubbed image bec…
6993998 
…ause of half support
@Wumpf
enable image and tensor roundtrip test
5abdf27
@Wumpf
tensor_simple example for c++
19ee63e
@Wumpf
potentially missing headers
87c8823
@Wumpf
shorten tensor-like archetype constructors by taking dimensions & dat…
d233e4e 
…a directly
@Wumpf Wumpf added examples Issues relating to the Rerun examples 🌊 C++ API C/C++ API specific exclude from changelog PRs with this won't show up in CHANGELOG.md labels Oct 17, 2023
@emilk emilk self-requested a review October 18, 2023 07:30
emilk
emilk approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must be careful to always reinforce the height, width order of our tensor dimensions, as that will undoubtedly be unconventional for many users

rerun_cpp/src/rerun/archetypes/depth_image_ext.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/archetypes/depth_image_ext.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/archetypes/depth_image_ext.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/archetypes/image_ext.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/archetypes/image_ext.cpp Outdated Show resolved Hide resolved
rerun_cpp/src/rerun/archetypes/tensor_ext.cpp Show resolved Hide resolved
rerun_cpp/src/rerun/archetypes/tensor_ext.cpp Outdated Show resolved Hide resolved
tests/cpp/roundtrips/image/main.cpp Outdated Show resolved Hide resolved
tests/python/roundtrips/image/main.py Outdated Show resolved Hide resolved
tests/rust/roundtrips/image/src/main.rs Show resolved Hide resolved
@Wumpf Wumpf force-pushed the andreas/cpp/images branch from 1a43cc5 to 450902f Compare October 18, 2023 08:14
@Wumpf Wumpf merged commit 582f2fd into main Oct 18, 2023
@Wumpf Wumpf deleted the andreas/cpp/images branch October 18, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++: Tensor migration to archetypes
2 participants
@Wumpf @emilk