Combine all Rust code-examples into one binary
#4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🧑💻 dev experience
|
The |
Wumpf
reviewed
Jan 10, 2024
docs/code-examples/README.md
Outdated
| - **Python**: `python <example_name>.py`, e.g. `python point3d_random.py`. | ||
| - **Rust**: `cargo r -p code_examples --bin <example_name`, e.g. `cargo r -p code_examples --bin point3d_random`. | ||
| - **Rust**: `cargo run -p code_examples -- <example_name`, e.g. `cargo run -p code_examples -- point3d_random`. |
There was a problem hiding this comment.
come to think it's a bit strange that they have different names in all languages!
- cpp: doc examples
- python: example name
- rust: code examples
can we unify this?
There was a problem hiding this comment.
I'll save that for a follow-up PR
Co-authored-by: Andreas Reich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This reduces the number of binaries in our workspace from 99 to 55.
We do this by joining all
docs/code-examplesinto one binary, with a little help from somebuild.rscodegen.This will any compiler error messages to the wrong file though, so it is not a perfect solution by any means.
I also decided to put all the code examples in their own folder (
docs/code-examples/all), with the control structures (Cargo.toml,CMakeLists, …) in the parent folder (docs/code-examples). If you have a better idea for a name than "all" I'm all ears.Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io