Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controlnet example readme #5490

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Update controlnet example readme #5490

merged 6 commits into from
Mar 20, 2024

Conversation

BirgerMoell
Copy link
Contributor

@BirgerMoell BirgerMoell commented Mar 13, 2024

What

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

Copy link

github-actions bot commented Mar 13, 2024

Size changes

Name main 5490/merge Change
incremental_logging.rrd (none) 0.0 MiB +100%

Copy link
Member

@nikolausWest nikolausWest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things to fix but generally good!

examples/python/controlnet/README.md Outdated Show resolved Hide resolved
examples/python/controlnet/README.md Outdated Show resolved Hide resolved
examples/python/controlnet/README.md Outdated Show resolved Hide resolved
examples/python/controlnet/README.md Outdated Show resolved Hide resolved
examples/python/controlnet/README.md Outdated Show resolved Hide resolved
@nikolausWest nikolausWest added 📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 13, 2024
@nikolausWest
Copy link
Member

Alright, @BirgerMoell, this looks good to me now. You just need to take it home by making the PR pass.

  • Spellcheck looks like you need to add some words to cspell.json
  • You need to check the relevant checkboxes on the PR

@emilk emilk changed the title Updated Controlnet example Update controlnet example readme Mar 15, 2024
@emilk emilk merged commit 7e59018 into main Mar 20, 2024
31 checks passed
@emilk emilk deleted the controlnet-example branch March 20, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation examples Issues relating to the Rerun examples exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants