Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding all TimePanel/BlueprintPanel/SelectionPanel #6407

Merged
merged 8 commits into from
May 22, 2024

Conversation

jprochazk
Copy link
Member

@jprochazk jprochazk commented May 22, 2024

What

  • App blueprint panel state now uses an enum instead of a bool to determine if each panel is hidden, collapsed, or expanded
  • App blueprint now also includes top panel state

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jprochazk jprochazk added ui concerns graphical user interface 🟦 blueprint The data that defines our UI include in changelog labels May 22, 2024
Copy link

github-actions bot commented May 22, 2024

Deployed docs

Commit Link
99f7e20 https://landing-gpdyyla1y-rerun.vercel.app/docs

@Wumpf Wumpf changed the title Refactor panel state to use Hidden/Collapsed/Expanded tri state Allow hiding all panels (including - new! - the menu bar) May 22, 2024
@Wumpf Wumpf changed the title Allow hiding all panels (including - new! - the menu bar) Allow hiding all panels (including the menu bar!) May 22, 2024
crates/re_viewer/src/ui/top_panel.rs Outdated Show resolved Hide resolved
@jprochazk jprochazk merged commit 364ed5c into main May 22, 2024
26 of 29 checks passed
@jprochazk jprochazk deleted the jan/panel-state branch May 22, 2024 16:55
@Wumpf Wumpf changed the title Allow hiding all panels (including the menu bar!) Allow hiding all TimePanel/BlueprintPanel/SelectionPanel May 22, 2024
jprochazk added a commit that referenced this pull request May 22, 2024
### What

Strings now autocomplete in places where we use enum classes that get
converted from strings.

Follow up to #6407

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6408?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6408?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6408)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants