Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confusing code around plot marker size vs stroke width #6630

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Jun 25, 2024

What

The existing code was using the same field to mean different things at different times. I have no idea if the original code was buggy, since it didn't document expected behavior.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jun 25, 2024
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should note the difference in diameter vs radius in the migration guide as well then 🤔

@emilk
Copy link
Member Author

emilk commented Jun 25, 2024

Assuming there is a change. The previous MarkerSize did not document if the size referred to the radius, diameter, or something else.

@emilk emilk merged commit 0bae519 into main Jun 25, 2024
36 of 37 checks passed
@emilk emilk deleted the emilk/fix-marker-size-code branch June 25, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants