Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish rerun_notebook in CI #6641

Merged
merged 22 commits into from
Jun 28, 2024
Merged

Publish rerun_notebook in CI #6641

merged 22 commits into from
Jun 28, 2024

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jun 25, 2024

What

This PR adds support for publishing rerun_notebook in CI. It also bumps all the versions as a result of running/merging alphas off this branch.

Wheel index for alpha.8: https://storage.googleapis.com/rerun-builds/commit/a6a666f/wheels/index.html

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@abey79 abey79 added this to the 0.17 milestone Jun 25, 2024
Copy link

github-actions bot commented Jun 25, 2024

Deployed docs

Commit Link
576c8ce https://landing-miqmmivrc-rerun.vercel.app/docs

abey79 and others added 9 commits June 25, 2024 16:57
### Next steps
- Test the release
- If this is an 'alpha' release, you can just merge the pull request.
- Otherwise:
  - For any added commits, run the release workflow in 'rc' mode again
- After testing, _ensure that this PR is mergeable to _, then run the
release workflow in 'release' mode
- Once the final release workflow finishes it will create a GitHub
release for you. Then:
    - [ ] Sanity check the build artifacts:
      - [ ] pip install: does it install and run?
      - [ ] cargo install of cli tool: does it install and run?
      - [ ] C++ SDK zip: does it contain rerun_c for all platforms?
- [ ] Populate the release with the changelog and a nice header
video/picture, check , then click .
- [ ] Make sure the [conda feedstock
PR](https://github.com/conda-forge/rerun-sdk-feedstock/pulls) gets
merged. This will be created by the once the GitHub release is created.
- [ ] Update the [google colab
notebooks](https://drive.google.com/drive/folders/0AC0q24MFKh3fUk9PVA)
to install this version and re-execute the notebook.
    - [ ] Merge this PR

- [ ] Tests
  - [ ] Windows
  - [ ] Linux
  - [ ] MacOS
# Conflicts:
#	pixi.lock
#	rerun_notebook/pyproject.toml
### Next steps
- Test the release
- If this is an 'alpha' release, you can just merge the pull request.
- Otherwise:
  - For any added commits, run the release workflow in 'rc' mode again
- After testing, _ensure that this PR is mergeable to _, then run the
release workflow in 'release' mode
- Once the final release workflow finishes it will create a GitHub
release for you. Then:
    - [ ] Sanity check the build artifacts:
      - [ ] pip install: does it install and run?
      - [ ] cargo install of cli tool: does it install and run?
      - [ ] C++ SDK zip: does it contain rerun_c for all platforms?
- [ ] Populate the release with the changelog and a nice header
video/picture, check , then click .
- [ ] Make sure the [conda feedstock
PR](https://github.com/conda-forge/rerun-sdk-feedstock/pulls) gets
merged. This will be created by the once the GitHub release is created.
- [ ] Update the [google colab
notebooks](https://drive.google.com/drive/folders/0AC0q24MFKh3fUk9PVA)
to install this version and re-execute the notebook.
    - [ ] Merge this PR

- [ ] Tests
  - [ ] Windows
  - [ ] Linux
  - [ ] MacOS
### Next steps
- Test the release
- If this is an 'alpha' release, you can just merge the pull request.
- Otherwise:
  - For any added commits, run the release workflow in 'rc' mode again
- After testing, _ensure that this PR is mergeable to _, then run the
release workflow in 'release' mode
- Once the final release workflow finishes it will create a GitHub
release for you. Then:
    - [ ] Sanity check the build artifacts:
      - [ ] pip install: does it install and run?
      - [ ] cargo install of cli tool: does it install and run?
      - [ ] C++ SDK zip: does it contain rerun_c for all platforms?
- [ ] Populate the release with the changelog and a nice header
video/picture, check , then click .
- [ ] Make sure the [conda feedstock
PR](https://github.com/conda-forge/rerun-sdk-feedstock/pulls) gets
merged. This will be created by the once the GitHub release is created.
- [ ] Update the [google colab
notebooks](https://drive.google.com/drive/folders/0AC0q24MFKh3fUk9PVA)
to install this version and re-execute the notebook.
    - [ ] Merge this PR

- [ ] Tests
  - [ ] Windows
  - [ ] Linux
  - [ ] MacOS
@abey79 abey79 marked this pull request as ready for review June 26, 2024 06:53
abey79 and others added 10 commits June 26, 2024 09:13
### What

- Closes #6646

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6648?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6648?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6648)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to my untrained eyes. Maybe @jleibs wanna take a look too?

@jleibs jleibs merged commit f29f519 into main Jun 28, 2024
39 of 40 checks passed
@jleibs jleibs deleted the antoine/rerun-notebook-publish branch June 28, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants