Remove Axes3D archetype and add axis_length to Transform3D #6676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
It turns out having a visualizer with no required entities causes all kinds of problems. This moves us back to only allowing axes if you have a transform at an entity.
The heuristics are still a bit fancy for backwards compatibility. We don't use Transform3D as an indicator since that would cause every transform to get axes by default. Instead, we only create the Transform3D visualizer if:
Shortcomings
default
to force the Transform3D axes to be visible.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.