Forward Rust (de-)serialization of transparent datatypes #6793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove lots of redundant serialization code by forwarding transparent components to its datatypes:
from_arrow_opt
for fully transparent typesfrom_arrow
for fully transparent typesdatatypes
!bytemuck
when possible. Should be possible in more places, but the constraints are complicated so this isn't fully automated and depends on types being manually marked asbytemuck::Pod
* would be really nice though if we could automate that. Almost everything we're dealing with should be pod 🤔
to_arrow_opt
for fully transparent typesarrow_datatype
for fully transparent types@ reviewer: There's only two non-generated files:
crates/re_types_builder/src/codegen/rust/api.rs
: https://github.com/rerun-io/rerun/pull/6793/files#diff-4eb7d4aa8c72b1987ed00d1ad9c61782b9dd55d8b96a50a44156388fea8c67f9crates/re_types_builder/src/codegen/rust/deserializer.rs
: https://github.com/rerun-io/rerun/pull/6793/files#diff-91844032ca93ef2e29de6a660674273bfd6e836b26ae58c83fef09dcd8db1076Everything else is generated via those changes. You'll want to have a sampling of both datatypes & components.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.