New and improved iteration APIs for Chunks
#6989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
🧑💻 dev experience
teh-cmc
commented
Jul 25, 2024
6 tasks
Wumpf
approved these changes
Jul 26, 2024
| #[inline] | ||
| pub fn iter_indices(&self, timeline: &Timeline) -> impl Iterator<Item = (TimeInt, RowId)> + '_ { | ||
| if self.is_static() { | ||
| Either::Right(Either::Left(izip!( |
There was a problem hiding this comment.
nit: the way you decide when to pick left/right seems a bit arbitrary and is hard to read
There was a problem hiding this comment.
It is not arbitrary!
They should all follow this model:
- The first layer is always the emptiness layer:
Leftis empty,Rightis non-empty. - The second layer is the temporarily layer:
Leftis static,Rightis temporal. - Any layers beyond that follow the same pattern:
Leftdoesn't have something, whileRightdoes.
There was a problem hiding this comment.
Added a comment in the code reflecting that.
| let indices = izip!(std::iter::repeat(TimeInt::STATIC), self.row_ids()); | ||
|
|
||
| if let Some(validity) = list_array.validity() { | ||
| Either::Right(Either::Left(Either::Left( |
There was a problem hiding this comment.
... not sure why I whined about double nested either earlier Oo. Maybe you want to introduce new IterVariants3 and IterVariants4 iterators which internally match things?
There was a problem hiding this comment.
Tbh I'd rather keep the nicely composable Either than introduce more ad-hoc things.
The caller never has to deal with them anyhow 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just bunch of brand new and/or improved iteration APIs for
Chunks.This will be used all over the place with the new query APIs, which will appear in a future PR.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.