New Chunk-based time-series views
#6995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
📺 re_viewer
6 tasks
teh-cmc
force-pushed
the
cmc/chunkified_queries_4_entitydb_integration
branch
from
8352397 to
d1331a4
Compare
Base automatically changed from
cmc/chunkified_queries_4_entitydb_integration
to
main
July 29, 2024 12:34
teh-cmc
force-pushed
the
cmc/chunkified_queries_5_new_time_series
branch
from
301c344 to
76c5d4a
Compare
jleibs
approved these changes
Jul 29, 2024
| .flat_map(|chunk| { | ||
| chunk.iter_component_indices(&query.timeline(), &Scalar::name()) | ||
| }) | ||
| .map(|index| (index, ())) |
There was a problem hiding this comment.
This looks odd. I assume this is related to the requirements for using range_zip_1x1 below, but maybe hints at the need for some helpers with slightly different shape if it shows up in more places.
There was a problem hiding this comment.
This only shows up in the time series views which are written in an awkward, rustc-pleasing kind of way.
It's still worthy of a comment in any case, you're right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
Chunk-based time-series views.They can chomp through your scalars real fast, here's 2.25M of them!
24-07-25_18.45.34.patched.mp4
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.