Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve entity stats when hovered #7074

Merged
merged 13 commits into from
Aug 7, 2024
Merged

Improve entity stats when hovered #7074

merged 13 commits into from
Aug 7, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Aug 6, 2024

What

When hovering an entity in e.g. the timeline view or blueprint view, we used to show the amount of memory used by that entity, as well as a data rate. It now also includes also the number of log rows.

To do this I improved the stats pipeline of re_chunk_store and EntityDb.

Best reviewed commit-by-commit

image

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added ui concerns graphical user interface include in changelog labels Aug 6, 2024
@teh-cmc teh-cmc self-requested a review August 7, 2024 07:24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point we might as well move these two to stats.rs I guess

crates/store/re_chunk_store/src/query.rs Outdated Show resolved Hide resolved
crates/store/re_log_types/src/time_point/mod.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 5fcc9fb into main Aug 7, 2024
34 checks passed
@emilk emilk deleted the emilk/better-chunk-stats branch August 7, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants