Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for RangeQueryOptions::include_extended_bounds #7132

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Aug 9, 2024

Introduces a new range query option include_extended_bounds, which allows the caller to grab one tick further at each end of the range, even for non-contiguous time values.

Pre-requisite for timeseries query clamping.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🔍 re_query affects re_query itself do-not-merge Do not merge this PR include in changelog labels Aug 9, 2024
@teh-cmc teh-cmc mentioned this pull request Aug 9, 2024
6 tasks
@teh-cmc teh-cmc force-pushed the cmc/extended_range_bounds branch from 65ed9d7 to e5b60d2 Compare August 9, 2024 15:50
@teh-cmc teh-cmc added do-not-merge Do not merge this PR and removed do-not-merge Do not merge this PR labels Aug 9, 2024
@teh-cmc teh-cmc marked this pull request as ready for review August 9, 2024 15:53
crates/store/re_chunk/src/range.rs Outdated Show resolved Hide resolved
Base automatically changed from cmc/generalized_query_options to main August 12, 2024 07:20
@teh-cmc teh-cmc force-pushed the cmc/extended_range_bounds branch from e5b60d2 to ce0c8a9 Compare August 12, 2024 07:21
Co-authored-by: Emil Ernerfeldt <[email protected]>
@teh-cmc teh-cmc removed the do-not-merge Do not merge this PR label Aug 12, 2024
@teh-cmc teh-cmc merged commit 179965b into main Aug 12, 2024
23 of 27 checks passed
@teh-cmc teh-cmc deleted the cmc/extended_range_bounds branch August 12, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants