Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2D objects in 3D affecting bounding box and thus causing flickering of automatic pinhole plane distance #7176

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Aug 14, 2024

What

If you have only a pinhole camera with some 2D objects in your scene, the viewer wasn't able to decide where to place that pinhole because the only source of bounding box information were those projected 2d elements.

We now simply ignore 2d visualizers when putting together the scene bounding box - since a little while this is a separate step that combines bounding boxes per entity per visualizer, making this pretty easy!

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself include in changelog labels Aug 14, 2024
@emilk emilk self-assigned this Aug 14, 2024
@Wumpf Wumpf merged commit 3c34516 into main Aug 14, 2024
33 of 34 checks passed
@Wumpf Wumpf deleted the andreas/fix-projection-bbox-contributions branch August 14, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants