Fix 2D objects in 3D affecting bounding box and thus causing flickering of automatic pinhole plane distance #7176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
If you have only a pinhole camera with some 2D objects in your scene, the viewer wasn't able to decide where to place that pinhole because the only source of bounding box information were those projected 2d elements.
We now simply ignore 2d visualizers when putting together the scene bounding box - since a little while this is a separate step that combines bounding boxes per entity per visualizer, making this pretty easy!
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.