Fix wasm-bindgen patch #7970
Merged
Fix wasm-bindgen patch #7970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
added
🕸️ web
|
It does work: https://github.com/rerun-io/rerun/actions/runs/11631337633/job/32392189416?pr=7970#step:8:324 I want to try improve the error |
|
Hopefully it's good enough: https://github.com/rerun-io/rerun/actions/runs/11631808301/job/32393617717?pr=7970#step:8:326 |
jleibs
approved these changes
Nov 1, 2024
Comment on lines
-34
to
-37
| child_process.execSync( | ||
| "cargo run -p re_dev_tools -- build-web-viewer --debug --target no-modules-base -o rerun_js/web-viewer", | ||
| { cwd: __dirname, stdio: "inherit" }, | ||
| ); |
There was a problem hiding this comment.
I'm confused by what these lines were doing previously.
There was a problem hiding this comment.
It was redundant, remainded here after I moved it to a function with copy instead of cut 😄
In practice it doubled build times, because everything was being built in both debug and release:
jleibs
pushed a commit
that referenced
this pull request
Nov 1, 2024
### What - Fixes the patch for `wasm-bindgen` output in `build-wasm.mjs` - The names of some variables changed (e.g. `cachedUint8Memory0` became `cachedUint8ArrayMemory0`) - Added an auto-generated file which stores one hash per file from the _unpatched_ output of `wasm-bindgen` - If the hash changes, that means the output has changed and the build will fail - We currently build the JS package on every PR, so we'll find out then and there - Note that the viewer we upload to GCS is _not_ patched, only the JS package (used in rerun.io/docs and notebooks) is patched. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7970?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7970?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7970) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
wasm-bindgenoutput inbuild-wasm.mjscachedUint8Memory0becamecachedUint8ArrayMemory0)wasm-bindgenChecklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.