-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hloc_glomap example and update manifest #8352
Conversation
thumbnail_dimensions = [480, 342] | ||
--> | ||
|
||
https://vimeo.com/1037241347?autoplay=1&loop=1&autopause=0&background=1&muted=1&ratio=2802:1790 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you wrap that in whatever html video tag is necessary for the video to be embedded in the readme please? (assuming that's even possible, but surely...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this so that it will render in the github? as I understand it, this is how Ive been doing it thus far for all other examples so that they would render on rerun.io example site.
For example
https://github.com/rerun-io/rerun/tree/main/examples/python/depth_compare
https://rerun.io/examples/generative-vision/depth_compare
I don't totally understand whats going on in the background on the rerun site, but from what I've tried before, if I put it in an iframe tag it still won't render on github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know better than me 👍
@rerun-bot approve |
Can you quickly fix the thumbnail issue to we can merge this @pablovela5620 ? 🙏
|
update thumbnail dimensions
Done! |
Related
What
rr-hloc-glomap.mp4
add python external example for Hloc-GLOMAP, this example show how to use rerun to visualize feature detection, feature matching, and reconstruction using the hloc repo and GLOMAP