Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hloc_glomap example and update manifest #8352

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

pablovela5620
Copy link
Contributor

Related

What

rr-hloc-glomap.mp4

add python external example for Hloc-GLOMAP, this example show how to use rerun to visualize feature detection, feature matching, and reconstruction using the hloc repo and GLOMAP

@pablovela5620 pablovela5620 marked this pull request as ready for review December 9, 2024 01:19
thumbnail_dimensions = [480, 342]
-->

https://vimeo.com/1037241347?autoplay=1&loop=1&autopause=0&background=1&muted=1&ratio=2802:1790
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wrap that in whatever html video tag is necessary for the video to be embedded in the readme please? (assuming that's even possible, but surely...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this so that it will render in the github? as I understand it, this is how Ive been doing it thus far for all other examples so that they would render on rerun.io example site.

For example
https://github.com/rerun-io/rerun/tree/main/examples/python/depth_compare
https://rerun.io/examples/generative-vision/depth_compare

I don't totally understand whats going on in the background on the rerun site, but from what I've tried before, if I put it in an iframe tag it still won't render on github

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know better than me 👍

@teh-cmc teh-cmc added examples Issues relating to the Rerun examples include in changelog labels Dec 9, 2024
@teh-cmc
Copy link
Member

teh-cmc commented Dec 9, 2024

@rerun-bot approve

@teh-cmc
Copy link
Member

teh-cmc commented Dec 10, 2024

Can you quickly fix the thumbnail issue to we can merge this @pablovela5620 ? 🙏

examples/python/hloc_glomap `thumbnail_dimensions` are incorrect (current: (480, 342), actual: (480, 300))

update thumbnail dimensions
@pablovela5620
Copy link
Contributor Author

Can you quickly fix the thumbnail issue to we can merge this @pablovela5620 ? 🙏

examples/python/hloc_glomap `thumbnail_dimensions` are incorrect (current: (480, 342), actual: (480, 300))

Done!

@teh-cmc teh-cmc merged commit 6fdb8c7 into rerun-io:main Dec 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues relating to the Rerun examples include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants