Make Archetype::{from_arrow, to_arrow} and friends tag compliant
#8644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
teh-cmc
added
🦀 Rust API
emilk
approved these changes
Jan 10, 2025
teh-cmc
force-pushed
the
cmc/eager_partial_1_descriptor_methods
branch
from
404b22f to
1404c21
Compare
Base automatically changed from
cmc/eager_partial_1_descriptor_methods
to
main
January 13, 2025 08:19
teh-cmc
force-pushed
the
cmc/eager_partial_2_tagged_from_to_arrow
branch
from
1ecedd4 to
13926a3
Compare
teh-cmc
added a commit
that referenced
this pull request
Jan 13, 2025
This introduces a new `attr.rust.archetype_eager` codegen attribute. When toggled, the associated archetype will now only carry raw Arrow data around, and go through the new eager logging APIs. The attribute has been set on `Points3D`:  Legacy and eagerly-serialized archetypes can co-exist, making it possible to migrate everything incrementally. * DNM: requires #8644 * Part of #7245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods were still
ComponentName-based, which just won't work as we start introducing archetypes with multiple instances of the same component.Note that these methods are very seldom used (only for tests, IIRC), so I went for the path of least resistance and took a few shortcuts.
We can build something sturdier later on if need be (I highly doubt it... in fact I expect these methods don't have that much time left to live).