Fix not handling empty line strips in the viewer #8653
+216
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🪳 bug
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
commented
Jan 10, 2025
| @@ -343,7 +343,7 @@ impl LineDrawData { | |||
|
|
|||
| let line_renderer = ctx.renderer::<LineRenderer>(); | |||
|
|
|||
| if strips_buffer.is_empty() { | |||
| if strips_buffer.is_empty() || vertices_buffer.is_empty() { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Adds a regression test for this so this doesn't happen again (this is vaguely familiar, I think this happened before) - which we can finally do now because we very recently ensured that we always have a (software) graphics device on ci \o/
Testing this directly in re_renderer required a little bit of new test framework, but it's fairly compact and unifies a bit of code we already had in the viewer.