Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@react-email/tailwind): Treat React as a peer dependency #1463

Merged
merged 1 commit into from
May 14, 2024

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented May 13, 2024

@react-email/tailwind declared react both as a direct and peer dependency. This means the peer dependency is rendered useless since the package manager will install a version of react right next to @react-email/tailwind instead of where it makes most sense to result in a single version react being used.

This is consistent with the other packages.

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email-demo ❌ Failed (Inspect) May 13, 2024 6:49pm

Copy link

vercel bot commented May 13, 2024

@eps1lon is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@gabrielmfern gabrielmfern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! This went unnoticed for some time.

@gabrielmfern gabrielmfern merged commit 6df2403 into resend:canary May 14, 2024
5 of 7 checks passed
@eps1lon eps1lon deleted the react-peer branch May 29, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants