Feat/on chain redemptions #3772
Annotations
6 errors and 11 warnings
test/rtoken-redemptions/EthPlusIntoEth.test.ts#L40
Replace `ethers.utils.parseEther('1'),·[]` with `⏎········ethers.utils.parseEther('1'),⏎········[]⏎······`
|
|
test/rtoken-redemptions/EthPlusIntoEth.test.ts#L51
Replace `⏎········Math.abs(outNum)⏎······` with `Math.abs(outNum)`
|
test/rtoken-redemptions/EthPlusIntoEth.test.ts#L55
Replace `"0x7cc1bfab73be4e02bb53814d1059a98cf7e49644"` with `⏎········'0x7cc1bfab73be4e02bb53814d1059a98cf7e49644'⏎······`
|
test/rtoken-redemptions/EthPlusIntoEth.test.ts#L63
Replace `"0x7cc1bfab73be4e02bb53814d1059a98cf7e49644"` with `⏎········'0x7cc1bfab73be4e02bb53814d1059a98cf7e49644'⏎······`
|
|
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
contracts/facade/Facade.sol#L30
When fallback is not payable you will not be able to receive ether
|
contracts/facade/Facade.sol#L30
Fallback function must be simple
|
contracts/facade/Facade.sol#L35
Avoid to use inline assembly. It is acceptable only in rare cases
|
contracts/facade/redeem/EthPlusIntoEth.sol#L100
Function name must be in mixedCase
|
contracts/facade/redeem/EthPlusIntoEth.sol#L124
Function name must be in mixedCase
|
contracts/facade/redeem/EthPlusIntoEth.sol#L346
Avoid to use low level calls
|
contracts/facade/redeem/EthPlusIntoEth.sol#L352
Code contains empty blocks
|
contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L9
Variable name must be in mixedCase
|
contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L10
Variable name must be in mixedCase
|
contracts/plugins/assets/curve/L2ConvexStableCollateral.sol#L45
Code contains empty blocks
|
This job failed
Loading