Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

possible bug in demand function #21

Closed
AtrCheema opened this issue Nov 30, 2018 · 1 comment
Closed

possible bug in demand function #21

AtrCheema opened this issue Nov 30, 2018 · 1 comment

Comments

@AtrCheema
Copy link

AtrCheema commented Nov 30, 2018 •
edited by aufdenkampe
Loading

There is a possible bug in 'demand' function in hrchhyd.py. Try running 'demand' function without jit with following input

vol = 0.0
rowFT = np.array([0.,   0.01, 0.,   0.,  ])
funct = (1,)
nexits = 1
delts = 3600.0
convf = 1.0
colind = [4.2]
outdgt = [2.1]
ODGTF = (0,)

and it will throw the error

  File "E:/debug/test.py", line 51, in demand2
    od[i] = _od1 + diff * (_od1 - rowFT[icol]) * convf                #$2356 

IndexError: index 4 is out of bounds for axis 0 with size 4

The problem with numba is that when we try to access a non-existent value in an array, it just gives a junk value like 1e-313 etc.
PaulDudaRESPEC added a commit that referenced this issue Apr 9, 2021
@PaulDudaRESPEC
GQUAL.py -- small fix for nexits subscript in response to issue #21
98d44f0
PaulDudaRESPEC pushed a commit that referenced this issue Apr 30, 2021
@aufdenkampe
Add WDM Programmers Guide
762b90c 
From @PaulDudaRESPEC, added to new `docs` directory that we'll want to build out over time. Connects to #20 & #21.
PaulDudaRESPEC pushed a commit that referenced this issue Apr 30, 2021
@aufdenkampe
Adding rpo772.wdm debugging files
b6fbef4 
.exp & .OUT files from @@jlkittle using WDMRX debugger: https://github.com/respec/FORTRAN/blob/master/lib3.0/BIN/WDMRX.EXE
CSV file from @htaolimno using https://github.com/respec/BASINS/tree/master/atcWdmVb
Connects to #21 & #22.
PaulDudaRESPEC pushed a commit that referenced this issue Apr 30, 2021
@aufdenkampe
Test10 no longer runs since readWDM time series updates
2a8373e 
@ptomasula, try running either of these notebooks.
Connects to issue #21 & PR #35
PaulDudaRESPEC pushed a commit that referenced this issue Apr 30, 2021
@ptomasula
Stop datetime fix
543ea20 
This commit addresses a mismatch in the 'Stop' parameter of the '/TIMESERIES/SUMMARY' table. The updated WDMreader wrote a value 1 timestep less than the end of the last group in the timeseries. See Issue #21.
@aufdenkampe
Copy link
Collaborator

I think this was fully fixed with #40.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aufdenkampe @AtrCheema