Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable turbo in /admin #1414

Open
donrestarone opened this issue Feb 15, 2023 · 3 comments
Open

enable turbo in /admin #1414

donrestarone opened this issue Feb 15, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@donrestarone
Copy link
Contributor

Is your feature request related to a problem? Please describe.
currently turbo is not enabled in admin, causing the browser to open on mobile devices

Describe the solution you'd like
just like turbo works on the website and forum, it should work in admin

@donrestarone donrestarone added the enhancement New feature or request label Feb 15, 2023
@donrestarone
Copy link
Contributor Author

enable turbo in sign in, and make sure 2FA works:

Screen Shot 2023-02-15 at 6 59 39 PM

@donrestarone
Copy link
Contributor Author

@donrestarone
Copy link
Contributor Author

donrestarone commented Feb 27, 2023

based on the stack trace below, I believe the issue is in the authenticate_with_otp_two_factor method's render call in app/controllers/concerns/twofactor_authenticable.rb

solutions_app        | Started POST "/users/sign_in" for 172.28.0.1 at 2023-02-27 19:23:41 +0000                          
solutions_app        | source=rack-timeout id=0c13e32b-fc50-4a10-ab03-ad6cc95fda71 timeout=200000ms service=3ms state=acti
ve                                                                                                                        
solutions_app        |   Subdomain Load (0.5ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "public".
"subdomains"."name" = $1 LIMIT $2  [["name", "public"], ["LIMIT", 1]]                                                     
solutions_app        |   ↳ app/models/subdomain.rb:61:in `current'                                                        
solutions_app        |   Subdomain Load (0.5ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "public".
"subdomains"."name" = $1 LIMIT $2  [["name", "root"], ["LIMIT", 1]]                                                       
solutions_app        |   ↳ app/models/subdomain.rb:65:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "public"], ["LIMIT", 1]]                                               
solutions_app        |   ↳ app/models/subdomain.rb:61:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "root"], ["LIMIT", 1]]                                                 
solutions_app        |   ↳ app/models/subdomain.rb:65:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "public"], ["LIMIT", 1]]                                               
solutions_app        |   ↳ app/models/subdomain.rb:61:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "root"], ["LIMIT", 1]]                                                 
solutions_app        |   ↳ app/models/subdomain.rb:65:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "public"], ["LIMIT", 1]]                                               
solutions_app        |   ↳ app/models/subdomain.rb:61:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "root"], ["LIMIT", 1]]                                                 
solutions_app        |   ↳ app/models/subdomain.rb:65:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "public"], ["LIMIT", 1]]                                               
solutions_app        |   ↳ app/models/subdomain.rb:61:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "root"], ["LIMIT", 1]]                                                 
solutions_app        |   ↳ app/models/subdomain.rb:65:in `current'                                                        
solutions_app        | Cannot render console from 172.28.0.1! Allowed networks: 127.0.0.0/127.255.255.255, ::1            
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "public"], ["LIMIT", 1]]                                               
solutions_app        |   ↳ app/models/subdomain.rb:61:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "root"], ["LIMIT", 1]]                                                 
solutions_app        |   ↳ app/models/subdomain.rb:65:in `current'                                                        
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "public"], ["LIMIT", 1]]                                               
solutions_app        |   ↳ app/models/subdomain.rb:61:in `current'
solutions_app        |   CACHE Subdomain Load (0.0ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "pu
blic"."subdomains"."name" = $1 LIMIT $2  [["name", "root"], ["LIMIT", 1]]
solutions_app        |   ↳ app/models/subdomain.rb:65:in `current'
solutions_app        |   Subdomain Load (0.6ms)  SELECT "public"."subdomains".* FROM "public"."subdomains"
solutions_app        |   ↳ config/initializers/apartment.rb:54:in `each_with_object'
solutions_app        | Processing by Users::SessionsController#create as TURBO_STREAM
solutions_app        |   Parameters: {"authenticity_token"=>"[FILTERED]", "user"=>{"email"=>"[email protected]", "password"
=>"[FILTERED]", "remember_me"=>"0"}, "commit"=>"Log in"}
solutions_app        |   User Load (1.1ms)  SELECT "users".* FROM "users" WHERE "users"."email" = $1 LIMIT $2  [["email", 
"[email protected]"], ["LIMIT", 1]]
solutions_app        |   ↳ app/controllers/concerns/twofactor_authenticable.rb:69:in `find_user'
solutions_app        |   Subdomain Load (0.7ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "public".
"subdomains"."name" = $1 LIMIT $2  [["name", "public"], ["LIMIT", 1]]
solutions_app        |   ↳ app/models/subdomain.rb:61:in `current'
solutions_app        |   Subdomain Load (0.7ms)  SELECT "public"."subdomains".* FROM "public"."subdomains" WHERE "public".
"subdomains"."name" = $1 LIMIT $2  [["name", "root"], ["LIMIT", 1]]
solutions_app        |   ↳ app/models/subdomain.rb:65:in `current'
solutions_app        |   CACHE User Load (0.0ms)  SELECT "users".* FROM "users" WHERE "users"."email" = $1 LIMIT $2  [["em
ail", "[email protected]"], ["LIMIT", 1]]
solutions_app        |   ↳ app/controllers/concerns/twofactor_authenticable.rb:69:in `find_user'
solutions_app        | [ActiveJob] Enqueued ActionMailer::MailDeliveryJob (Job ID: 59403628-d2b9-411f-a78b-eafc66b76f3f) t
o Sidekiq(default) with arguments: "UserMailer", "send_otp", "deliver_now", {:args=>[#<GlobalID:0x0000ffff7dc84790 @uri=#<
URI::GID gid://r-solutions/User/1>>]}
solutions_sidekiq    | 2023-02-27T19:23:41.609Z pid=1 tid=1dvxl651rd class=ActionMailer::MailDeliveryJob jid=0e37ed83ac07a
c9e04072cde INFO: start
solutions_app        |   Rendering layout layouts/devise.html.haml
solutions_app        |   Rendering users/sessions/two_factor.html.erb within layouts/devise
solutions_app        |   Rendered users/sessions/two_factor.html.erb within layouts/devise (Duration: 4.1ms | Allocations:
 599)

donrestarone pushed a commit that referenced this issue Apr 29, 2023
donrestarone added a commit that referenced this issue Apr 29, 2023
Addresses: #1414 & #820

Addresses: #1414 & #820

## Allow login on iOS

<img width="503" alt="Screen Shot 2023-04-28 at 10 38 00 PM" src="https://user-images.githubusercontent.com/35935196/235279807-f985c695-07d4-40b5-a8dc-26aa7e045286.png">

## Access Forum, Web app and Admin Index 
<img width="496" alt="Screen Shot 2023-04-28 at 10 37 39 PM" src="https://user-images.githubusercontent.com/35935196/235279808-7d061262-318a-408c-8eec-896365d69359.png">



Co-authored-by: Pralish Kayastha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant