Entity specific analytics (#1323) #1332

donrestarone · 2023-01-03T22:27:31Z

Addresses: #1292

* page visit graph * page visit graph * page visit chart * customize chartkick legends

github-actions · 2023-01-03T22:36:04Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

github-actions · 2023-01-04T17:36:41Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

donrestarone · 2023-01-09T15:49:06Z

@Pralish some feedback:

Rename Visitor Analytics to Analytics

unify dropdown style between the two dropdowns shown below. It should be clear to the user that they are dropdowns

github-actions · 2023-01-17T02:43:11Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

…shentity_specific_analytics

…ne/violet_rails into Pralishentity_specific_analytics

github-actions · 2023-01-18T17:40:04Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

donrestarone · 2023-01-18T18:12:05Z

app/javascript/packs/violet_analytics.js

@@ -0,0 +1,61 @@
+$(document).on("turbo:load", () => {


https://nikean.org story platform uses non-turbo navigation but the static site uses turbo. We should accommodate both cases

github-actions · 2023-01-20T17:39:41Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

donrestarone · 2023-01-20T22:57:35Z

@Ayon95 with this analytics PR coming together nicely, we need a way to test it.

Could you add analytics instrumentation in the testnet (http://violet-test.net) to the spots marked below?

github-actions · 2023-01-21T16:40:51Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

donrestarone · 2023-01-21T17:21:39Z

@Pralish Some feedback:

there are events as indicated in Legacy Analytics,

but they are not shown in Analytics V2

Please show events in a similar UI as Clicks and Watch Time (name it Events) :

Clicking on each event should lead to `dashboard/events/:event_slug`

Do not show Clicks / Watch Time / Events if none exist, instead render dynamic docs:

For docs, be sure to show an example each for tracking: section views, countable events, watch time, clicks

API Form submissions are not shown, they should be shown in a similar UI to Clicks and Watch time where each namespace/submission count should lead to the API Namespace #show page

Ayon95 · 2023-01-22T05:52:10Z

I've added the necessary data attributes to the navbar links and car page links.

Car links:

Navbar links:

github-actions · 2023-01-28T13:15:19Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

Pralish · 2023-01-28T13:15:28Z

@ajaystha42 , @donrestarone ,thanks for the feedbacks

Do we need to add the following showing gain/loss percentage?

That was the design requirement.

API Form submissions are shown, but each namespace/submission count isn't leading to the API Namespace #show page

@donrestarone, didn't we decide to not implement that? Wouldn't having redirection on count on form submission make the design inconsistent with the rest of the section?

donrestarone · 2023-01-28T14:05:30Z

@Pralish

@donrestarone, didn't we decide to not implement that? Wouldn't having redirection on count on form submission make the design inconsistent with the rest of the section?

yup! The current implementation is fine

about the analytics mapping you will need to add the permission for it (please call it allow analytics mapping):

donrestarone · 2023-01-28T14:08:56Z

app/views/layouts/comfy/admin/cms.html.haml

@@ -9,8 +9,9 @@
  -# this is a hack until I figure out how to get chartkick working without importing the whole application js pack
  - if controller_name == 'dashboard'
    = javascript_pack_tag 'application', 'data-turbo-track': 'reload'
-
-
+    %script{type: "text/javascript", src: "//cdn.jsdelivr.net/momentjs/latest/moment.min.js"}


@Pralish can we install these instead of pulling the latest from a CDN? We are vulnerable to breakages due to changes with the current implementation

donrestarone · 2023-01-28T15:13:38Z

@Pralish found a bug, the custom events are not scoped by time period (eg: 1 month, 3 months etc):

github-actions · 2023-01-29T15:36:51Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

donrestarone · 2023-01-29T15:45:05Z

@Pralish I took a look at the latest commits and the Date dropdown is broken on mobile/desktop and there is broken HTML at the bottom of the page:

RPReplay_Final1675007003.MP4

on desktop the viewport is broken as well:

broken.viewport.mov

github-actions · 2023-01-29T15:53:15Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

donrestarone · 2023-01-29T17:02:46Z

@Pralish I back merged master into this branch (70526b5) we should always keep feature branches caught up with master in the later stages of the development to avoid unforeseen issues

github-actions · 2023-01-29T17:09:38Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

…ne/violet_rails into Pralishentity_specific_analytics

github-actions · 2023-01-30T01:39:23Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

donrestarone · 2023-01-30T01:49:29Z

⚠️ horizontal scrolling on iPhone on the event show page:

RPReplay_Final1675043264.MP4

⚠️ scoping of the events by date range (fix WIP):

github-actions · 2023-01-30T02:47:28Z

Deployed review-app can be viewed at https://review-1332.violet-test.net

[WIP] Entity specific analytics (#1323)

9fc69c4

* page visit graph * page visit graph * page visit chart * customize chartkick legends

donrestarone added deploy-review-app do not merge labels Jan 3, 2023

compute percent change with previous data

1e07234

donrestarone assigned alis-khadka Jan 9, 2023

Merge branch 'master' into Pralishentity_specific_analytics

fd84ca0

Pralish added 3 commits January 17, 2023 20:23

Merge branch 'master' of github.com:restarone/violet_rails into Prali…

df80ce1

…shentity_specific_analytics

track common events

4d1ff71

Merge branch 'Pralishentity_specific_analytics' of github.com:restaro…

3a55619

…ne/violet_rails into Pralishentity_specific_analytics

donrestarone commented Jan 18, 2023

View reviewed changes

Pralish added 2 commits January 20, 2023 09:26

avoid tracking when seeking

17e981c

video tracking, UI updates

d2a7e91

Pralish added 6 commits January 21, 2023 14:17

range start from begining to end of day

4f17c0b

add tooltips

2211102

fix dropdown color

29eeb7a

dynamic title for visit events

cda64a0

ability to track section views, event category const

676544a

change const name

597c1f6

default event name and values

2763670

donrestarone removed the deploy-review-app label Jan 22, 2023

Pralish added 3 commits January 28, 2023 09:58

fix event url

a15cf14

track video event when tab is closed, or redirected

e4d0373

responsive design , dynamic count for top 3 videos

027277a

donrestarone commented Jan 28, 2023

View reviewed changes

Pralish added 4 commits January 29, 2023 08:46

fix pythin missing err and install daterangepicker

4386315

use datepicker from node_modules

2829b93

responsive filters

8d77f3b

responsive filters

f920fe3

responsive subtotle

eedbfa4

Merge branch 'master' into Pralishentity_specific_analytics

70526b5

Pralish added 2 commits January 30, 2023 07:14

fix datrangepicker, fix responsive header

545bdba

Merge branch 'Pralishentity_specific_analytics' of github.com:restaro…

15f98b6

…ne/violet_rails into Pralishentity_specific_analytics

Pralish added 2 commits January 30, 2023 08:23

fix event filtwer

9a78c3e

fix horizontal scroll

769933b

Pralish changed the title ~~[WIP] Entity specific analytics (#1323)~~ Entity specific analytics (#1323) Jan 30, 2023

Pralish marked this pull request as ready for review January 30, 2023 04:31

donrestarone changed the base branch from master to rc January 30, 2023 04:36

donrestarone merged commit 3cb3964 into rc Jan 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Entity specific analytics (#1323) #1332

Entity specific analytics (#1323) #1332

donrestarone commented Jan 3, 2023 •

edited

Loading

github-actions bot commented Jan 3, 2023

github-actions bot commented Jan 4, 2023

donrestarone commented Jan 9, 2023

github-actions bot commented Jan 17, 2023

github-actions bot commented Jan 18, 2023

donrestarone Jan 18, 2023 •

edited

Loading

github-actions bot commented Jan 20, 2023

donrestarone commented Jan 20, 2023

github-actions bot commented Jan 21, 2023

donrestarone commented Jan 21, 2023

Ayon95 commented Jan 22, 2023

github-actions bot commented Jan 28, 2023

Pralish commented Jan 28, 2023

donrestarone commented Jan 28, 2023

donrestarone Jan 28, 2023

donrestarone commented Jan 28, 2023

github-actions bot commented Jan 29, 2023

donrestarone commented Jan 29, 2023 •

edited

Loading

github-actions bot commented Jan 29, 2023

donrestarone commented Jan 29, 2023

github-actions bot commented Jan 29, 2023

github-actions bot commented Jan 30, 2023

donrestarone commented Jan 30, 2023

github-actions bot commented Jan 30, 2023

Entity specific analytics (#1323) #1332

Entity specific analytics (#1323) #1332

Conversation

donrestarone commented Jan 3, 2023 • edited Loading

github-actions bot commented Jan 3, 2023

github-actions bot commented Jan 4, 2023

donrestarone commented Jan 9, 2023

github-actions bot commented Jan 17, 2023

github-actions bot commented Jan 18, 2023

donrestarone Jan 18, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jan 20, 2023

donrestarone commented Jan 20, 2023

github-actions bot commented Jan 21, 2023

donrestarone commented Jan 21, 2023

Ayon95 commented Jan 22, 2023

github-actions bot commented Jan 28, 2023

Pralish commented Jan 28, 2023

donrestarone commented Jan 28, 2023

donrestarone Jan 28, 2023

Choose a reason for hiding this comment

donrestarone commented Jan 28, 2023

github-actions bot commented Jan 29, 2023

donrestarone commented Jan 29, 2023 • edited Loading

github-actions bot commented Jan 29, 2023

donrestarone commented Jan 29, 2023

github-actions bot commented Jan 29, 2023

github-actions bot commented Jan 30, 2023

donrestarone commented Jan 30, 2023

github-actions bot commented Jan 30, 2023

donrestarone commented Jan 3, 2023 •

edited

Loading

donrestarone Jan 18, 2023 •

edited

Loading

donrestarone commented Jan 29, 2023 •

edited

Loading