Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awakeables test for node services #171

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Awakeables test for node services #171

merged 1 commit into from
Jul 24, 2023

Conversation

slinkydeveloper
Copy link
Collaborator

Fix #108

@slinkydeveloper slinkydeveloper requested a review from gvdongen July 21, 2023 08:20
@github-actions
Copy link

github-actions bot commented Jul 21, 2023

Test Results

  84 files  +3    84 suites  +3   6m 51s ⏱️ +6s
  67 tests +1    67 ✔️ +1  0 💤 ±0  0 ±0 
174 runs  +3  174 ✔️ +3  0 💤 ±0  0 ±0 

Results for commit e50b165. ± Comparison against base commit a1e28b5.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.
dev.restate.e2e.java.AwakeableTest ‑ generate(RandomNumberListGeneratorBlockingStub)
dev.restate.e2e.JavaAwakeableTest ‑ generate(RandomNumberListGeneratorBlockingStub)
dev.restate.e2e.NodeAwakeableTest ‑ generate(RandomNumberListGeneratorBlockingStub)

♻️ This comment has been updated with latest results.

@gvdongen
Copy link
Contributor

Looks good. +1 for merging.
I guess we can remove tests/src/test/kotlin/dev/restate/e2e/java/AwakeableTest.kt?

@slinkydeveloper slinkydeveloper merged commit 2591466 into main Jul 24, 2023
@slinkydeveloper slinkydeveloper deleted the issues/108 branch July 24, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for awakeables for node
2 participants