Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests #89

Merged
merged 26 commits into from
May 10, 2023
Merged

More tests #89

merged 26 commits into from
May 10, 2023

Conversation

slinkydeveloper
Copy link
Collaborator

@slinkydeveloper slinkydeveloper commented May 5, 2023 •
edited
Loading

This PR has an assorted number of changes to the infra:

  • Added ability to inject the grpc managed channel of the runtime, to create a custom stub
  • Allow to configure retry policy when deploying a function spec
  • Export traces as json, to allow importing them in jaeger for inspection
  • Introduce toxiproxy to avoid issue with port changes when restarting the runtime container
  • Enable testcontainers logs

Plus there are some new tests:

Depends on restatedev/restate#365

tillrohrmann
tillrohrmann approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for extending the e2e test suite @slinkydeveloper. The changes look good to me. I only had few minor comments. +1 for merging after resolving them.

test-utils/src/main/kotlin/dev/restate/e2e/utils/RestateDeployer.kt Show resolved Hide resolved
tests/src/test/kotlin/dev/restate/e2e/VerificationTest.kt Show resolved Hide resolved
tests/src/test/kotlin/dev/restate/e2e/VerificationTest.kt Outdated Show resolved Hide resolved
tests/src/test/kotlin/dev/restate/e2e/VerificationTest.kt Outdated Show resolved Hide resolved
tests/src/test/kotlin/dev/restate/e2e/VerificationTest.kt Outdated Show resolved Hide resolved
tests/src/test/kotlin/dev/restate/e2e/VerificationTest.kt Show resolved Hide resolved
tests/build.gradle.kts
Comment on lines +50 to +54
"RESTATE_RUNTIME_CONTAINER" to
(System.getenv("RESTATE_RUNTIME_CONTAINER")
?: "ghcr.io/restatedev/restate:latest"),
"RUST_LOG" to
(System.getenv("RUST_LOG") ?: "info,restate_invoker=trace,restate=debug"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

@slinkydeveloper slinkydeveloper mentioned this pull request May 5, 2023
Merged
@slinkydeveloper slinkydeveloper force-pushed the verification_test branch 4 times, most recently from 897e2c6 to 69e0583 Compare May 8, 2023 14:25
@slinkydeveloper slinkydeveloper force-pushed the verification_test branch 2 times, most recently from f35991d to a5555be Compare May 10, 2023 15:33
@slinkydeveloper slinkydeveloper merged commit 8a60c7a into main May 10, 2023
@slinkydeveloper slinkydeveloper deleted the verification_test branch May 10, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verification with failures (runtime, service endpoint)
2 participants
@slinkydeveloper @tillrohrmann