Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail pending journal entries other than calls with CanceledException #943

Closed
Tracked by #978
tillrohrmann opened this issue Dec 4, 2023 · 1 comment
Closed
Tracked by #978

Fail pending journal entries other than calls with CanceledException #943

tillrohrmann opened this issue Dec 4, 2023 · 1 comment
Assignees
@tillrohrmann

Comments

@tillrohrmann
Copy link
Contributor

No description provided.

@tillrohrmann tillrohrmann mentioned this issue Dec 4, 2023
Closed
@tillrohrmann tillrohrmann mentioned this issue Dec 12, 2023
Closed
@tillrohrmann tillrohrmann self-assigned this Dec 15, 2023
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 15, 2023
@tillrohrmann
Introduce graceful cancellation of invocations.
5238d06 
This commit introduces a new TerminationFlavor::Cancel which will
gracefully terminate an invocation. The way it works is that only
leaf operations are being terminated with a CANCELED_INVOCATION_ERROR.
Leaf operations are all completable journal entries except for calls
and inboxed invocations. For pending calls in a journal, a cancellation
will propagate the cancellation to these calls.

This commit adds support for canceling inboxed, invoked, suspended and
virtual invocations.

This fixes restatedev#986 and restatedev#943.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 15, 2023
@tillrohrmann
Introduce graceful cancellation of invocations
4036016 
This commit introduces a new TerminationFlavor::Cancel which will
gracefully terminate an invocation. The way it works is that only
leaf operations are being terminated with a CANCELED_INVOCATION_ERROR.
Leaf operations are all completable journal entries except for calls
and inboxed invocations. For pending calls in a journal, a cancellation
will propagate the cancellation to these calls.

This commit adds support for canceling inboxed, invoked, suspended and
virtual invocations.

This fixes restatedev#986 and restatedev#943.
@tillrohrmann tillrohrmann mentioned this issue Dec 15, 2023
Merged
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 18, 2023
@tillrohrmann
Introduce graceful cancellation of invocations
529a356 
This commit introduces a new TerminationFlavor::Cancel which will
gracefully terminate an invocation. The way it works is that only
leaf operations are being terminated with a CANCELED_INVOCATION_ERROR.
Leaf operations are all completable journal entries except for calls
and inboxed invocations. For pending calls in a journal, a cancellation
will propagate the cancellation to these calls.

This commit adds support for canceling inboxed, invoked, suspended and
virtual invocations.

This fixes restatedev#986 and restatedev#943.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 18, 2023
@tillrohrmann
Introduce graceful cancellation of invocations
5ce7bf3 
This commit introduces a new TerminationFlavor::Cancel which will
gracefully terminate an invocation. The way it works is that only
leaf operations are being terminated with a CANCELED_INVOCATION_ERROR.
Leaf operations are all completable journal entries except for calls
and inboxed invocations. For pending calls in a journal, a cancellation
will propagate the cancellation to these calls.

This commit adds support for canceling inboxed, invoked, suspended and
virtual invocations.

This fixes restatedev#986 and restatedev#943.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 18, 2023
@tillrohrmann
Introduce graceful cancellation of invocations
9a20d6f 
This commit introduces a new TerminationFlavor::Cancel which will
gracefully terminate an invocation. The way it works is that only
leaf operations are being terminated with a CANCELED_INVOCATION_ERROR.
Leaf operations are all completable journal entries except for calls
and inboxed invocations. For pending calls in a journal, a cancellation
will propagate the cancellation to these calls.

This commit adds support for canceling inboxed, invoked, suspended and
virtual invocations.

This fixes restatedev#986 and restatedev#943.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 18, 2023
@tillrohrmann
Introduce graceful cancellation of invocations
5988356 
This commit introduces a new TerminationFlavor::Cancel which will
gracefully terminate an invocation. The way it works is that only
leaf operations are being terminated with a CANCELED_INVOCATION_ERROR.
Leaf operations are all completable journal entries except for calls
and inboxed invocations. For pending calls in a journal, a cancellation
will propagate the cancellation to these calls.

This commit adds support for canceling inboxed, invoked, suspended and
virtual invocations.

This fixes restatedev#986 and restatedev#943.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 18, 2023
@tillrohrmann
Introduce graceful cancellation of invocations
06d05ff 
This commit introduces a new TerminationFlavor::Cancel which will
gracefully terminate an invocation. The way it works is that only
leaf operations are being terminated with a CANCELED_INVOCATION_ERROR.
Leaf operations are all completable journal entries except for calls
and inboxed invocations. For pending calls in a journal, a cancellation
will propagate the cancellation to these calls.

This commit adds support for canceling inboxed, invoked, suspended and
virtual invocations.

This fixes restatedev#986 and restatedev#943.
@tillrohrmann
Copy link
Contributor Author

Fixed via #986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tillrohrmann tillrohrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tillrohrmann