Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store caller information for background invokes #997

Closed
Tracked by #888
tillrohrmann opened this issue Dec 15, 2023 · 3 comments · Fixed by #1010
Closed
Tracked by #888

Store caller information for background invokes #997

tillrohrmann opened this issue Dec 15, 2023 · 3 comments · Fixed by #1010
Assignees
@tillrohrmann

Comments

@tillrohrmann
Copy link
Contributor

tillrohrmann commented Dec 15, 2023 •
edited
Loading

In order to also display for background invokes who was the caller, we should track this information in the runtime. I propose to not rely on the ResponseSink for extracting the caller information but to have a dedicated field for it.
@tillrohrmann tillrohrmann mentioned this issue Dec 15, 2023
Open
@tillrohrmann tillrohrmann self-assigned this Dec 15, 2023
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 19, 2023
@tillrohrmann
Track caller for each ServiceInvocation
b5e0bd9 
This commit introduces the Caller enum which each ServiceInvocation and
InvocationMetadata carries along. The Caller captures who was the caller
of the given service invocation. Currently Restate distinguishes between
three values:

* Caller::Ingress: Invocation originating from the ingress
* Caller::Service: Invocation originating from a Restate service
* Caller::Internal: Invocation originating from the Restate server to drive non-deterministic built-in services forward

This fixes restatedev#997.
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 19, 2023
@tillrohrmann
Track caller for each ServiceInvocation
2dc1d10 
This commit introduces the Caller enum which each ServiceInvocation and
InvocationMetadata carries along. The Caller captures who was the caller
of the given service invocation. Currently Restate distinguishes between
three values:

* Caller::Ingress: Invocation originating from the ingress
* Caller::Service: Invocation originating from a Restate service
* Caller::Internal: Invocation originating from the Restate server to drive non-deterministic built-in services forward

This fixes restatedev#997.
@tillrohrmann tillrohrmann mentioned this issue Dec 19, 2023
Merged
tillrohrmann added a commit to tillrohrmann/restate that referenced this issue Dec 20, 2023
@tillrohrmann
Track caller for each ServiceInvocation
63f66ca 
This commit introduces the Caller enum which each ServiceInvocation and
InvocationMetadata carries along. The Caller captures who was the caller
of the given service invocation. Currently Restate distinguishes between
three values:

* Caller::Ingress: Invocation originating from the ingress
* Caller::Service: Invocation originating from a Restate service
* Caller::Internal: Invocation originating from the Restate server to drive non-deterministic built-in services forward

This fixes restatedev#997.
@slinkydeveloper
Copy link
Contributor

I propose to not rely on the ResponseSink for extracting the caller information but to have a dedicated field for it.

@tillrohrmann can you elaborate on why relying on response sink was not considered an option here?

@tillrohrmann
Copy link
Contributor Author

Because for background calls the response sink would be None.

@slinkydeveloper
Copy link
Contributor

slinkydeveloper commented Mar 27, 2024 •
edited
Loading

Uh sorry i completely forgot that, makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tillrohrmann tillrohrmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Track caller for each ServiceInvocation tillrohrmann/restate
2 participants
@tillrohrmann @slinkydeveloper