Cloud CLI integration #1519
Merged
Cloud CLI integration #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
force-pushed
the
cloud-cli
branch
2 times, most recently
from
17b6ede to
0ecf9b3
Compare
AhmedSoliman
approved these changes
May 21, 2024
Comment on lines
+37
to
+42
| pub struct Envelope<T> { | ||
| inner: reqwest::Response, | ||
|
|
||
| _phantom: std::marker::PhantomData<T>, | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it intentional to copy the code from metas_client or is it possible to reuse existing implementation?
There was a problem hiding this comment.
im on the fence on this one. we now have 3 pretty similar client structs, but there are some subtle differences (eg whether we expect error responses to be valid json) and we might expect more divergence. i can unify them if you prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restate configsubcommandrestate cloud loginrestate cloud environment configure